Data race in tests: TestApplicationsUpgradeOverREST race

test/e2e-go/cli/algod/cleanup_test.go

@@ -29,6 +29,7 @@ import (
 
 func TestNodeControllerCleanup(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))

test/e2e-go/cli/algod/expect/algod_expect_test.go

@@ -25,6 +25,8 @@ import (
 // TestAlgodWithExpect Process all expect script files with suffix Test.exp within the test/e2e-go/cli/algod/expect directory
 func TestAlgodWithExpect(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
+
 	et := fixtures.MakeExpectTest(t)
 	et.Run()
 }

test/e2e-go/cli/algod/stdstreams_test.go

@@ -30,6 +30,7 @@ import (
 
 func TestAlgodLogsToFile(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 

test/e2e-go/cli/algoh/expect/algoh_expect_test.go

@@ -25,6 +25,7 @@ import (
 func TestAlgohWithExpect(t *testing.T) {
 	// partitiontest.PartitionTest(t)
 	// Causes double partition, so commented out on purpose
+	defer fixtures.ShutdownSynchronizedTest(t)
 	et := fixtures.MakeExpectTest(t)
 	et.Run()
 }

test/e2e-go/cli/goal/account_test.go

@@ -28,6 +28,7 @@ const statusOffline = "[offline]"
 const statusOnline = "[online]"
 
 func TestAccountNew(t *testing.T) {
+	defer fixtures.ShutdownSynchronizedTest(t)
 	defer fixture.SetTestContext(t)()
 	a := require.New(fixtures.SynchronizedTest(t))
 
@@ -53,6 +54,7 @@ func TestAccountNew(t *testing.T) {
 }
 
 func TestAccountNewDuplicateFails(t *testing.T) {
+	defer fixtures.ShutdownSynchronizedTest(t)
 	defer fixture.SetTestContext(t)()
 	a := require.New(fixtures.SynchronizedTest(t))
 
@@ -68,6 +70,7 @@ func TestAccountNewDuplicateFails(t *testing.T) {
 }
 
 func TestAccountRename(t *testing.T) {
+	defer fixtures.ShutdownSynchronizedTest(t)
 	defer fixture.SetTestContext(t)()
 	a := require.New(fixtures.SynchronizedTest(t))
 
@@ -98,6 +101,7 @@ func TestAccountRename(t *testing.T) {
 
 // Importing an account multiple times should not be considered an error by goal
 func TestAccountMultipleImportRootKey(t *testing.T) {
+	defer fixtures.ShutdownSynchronizedTest(t)
 	defer fixture.SetTestContext(t)()
 	a := require.New(fixtures.SynchronizedTest(t))
 

test/e2e-go/cli/goal/clerk_test.go

@@ -27,6 +27,7 @@ import (
 )
 
 func TestClerkSendNoteEncoding(t *testing.T) {
+	defer fixtures.ShutdownSynchronizedTest(t)
 	defer fixture.SetTestContext(t)()
 	a := require.New(fixtures.SynchronizedTest(t))
 

test/e2e-go/cli/goal/expect/goal_expect_test.go

@@ -26,6 +26,7 @@ import (
 func TestGoalWithExpect(t *testing.T) {
 	// partitiontest.PartitionTest(t)
 	// Causes double partition, so commented out on purpose
+	defer fixtures.ShutdownSynchronizedTest(t)
 	et := fixtures.MakeExpectTest(t)
 	et.Run()
 }

test/e2e-go/cli/goal/node_cleanup_test.go

@@ -26,7 +26,9 @@ import (
 )
 
 func TestGoalNodeCleanup(t *testing.T) {
+	defer fixtures.ShutdownSynchronizedTest(t)
 	defer fixture.SetTestContext(t)()
+
 	a := require.New(fixtures.SynchronizedTest(t))
 
 	primaryDir := fixture.PrimaryDataDir()

test/e2e-go/cli/tealdbg/expect/tealdbg_expect_test.go

@@ -25,6 +25,7 @@ import (
 func TestTealdbgWithExpect(t *testing.T) {
 	// partitiontest.PartitionTest(t)
 	// Causes double partition, so commented out on purpose
+	defer fixtures.ShutdownSynchronizedTest(t)
 	et := fixtures.MakeExpectTest(t)
 	et.Run()
 }

test/e2e-go/features/catchup/basicCatchup_test.go

@@ -33,6 +33,7 @@ import (
 
 func TestBasicCatchup(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()
@@ -80,6 +81,7 @@ func TestBasicCatchup(t *testing.T) {
 // The current versions are the original v1 and the upgraded to v2.1
 func TestCatchupOverGossip(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 
@@ -201,6 +203,7 @@ const consensusTestUnupgradedToProtocol = protocol.ConsensusVersion("test-unupgr
 
 func TestStoppedCatchupOnUnsupported(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()

test/e2e-go/features/catchup/catchpointCatchup_test.go

@@ -81,6 +81,7 @@ func (ec *nodeExitErrorCollector) Print() {
 
 func TestBasicCatchpointCatchup(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()

test/e2e-go/features/compactcert/compactcert_test.go

@@ -37,6 +37,7 @@ import (
 
 func TestCompactCerts(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Skip("Disabling since they need work and shouldn't block releases")
 	t.Parallel()

test/e2e-go/features/multisig/multisig_test.go

@@ -33,6 +33,7 @@ import (
 // try to transact with 3 sigs: expect success
 func TestBasicMultisig(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 
@@ -110,6 +111,7 @@ func TestBasicMultisig(t *testing.T) {
 // create a 0-of-3 multisig address: expect failure
 func TestZeroThreshold(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 
@@ -139,6 +141,7 @@ func TestZeroThreshold(t *testing.T) {
 // create a 3-of-0 multisig address: expect failure
 func TestZeroSigners(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 
@@ -164,6 +167,7 @@ func TestZeroSigners(t *testing.T) {
 // then try to transact
 func TestDuplicateKeys(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 

test/e2e-go/features/participation/onlineOfflineParticipation_test.go

@@ -34,6 +34,7 @@ import (
 
 func TestParticipationKeyOnlyAccountParticipatesCorrectly(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))
@@ -108,6 +109,8 @@ func waitForAccountToProposeBlock(a *require.Assertions, fixture *fixtures.RestC
 // - When the account balance receives enough stake, it should be proposing after lookback rounds
 func TestNewAccountCanGoOnlineAndParticipate(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
+
 	if testing.Short() {
 		t.Skip()
 	}

test/e2e-go/features/participation/overlappingParticipationKeys_test.go

@@ -41,6 +41,7 @@ import (
 
 func TestOverlappingParticipationKeys(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))

test/e2e-go/features/participation/participationRewards_test.go

@@ -78,6 +78,7 @@ func spendToNonParticipating(t *testing.T, fixture *fixtures.RestClientFixture,
 
 func TestOnlineOfflineRewards(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	r := require.New(fixtures.SynchronizedTest(t))
@@ -136,6 +137,7 @@ func TestOnlineOfflineRewards(t *testing.T) {
 
 func TestPartkeyOnlyRewards(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if runtime.GOOS == "darwin" {
 		t.Skip()
@@ -187,6 +189,7 @@ func TestPartkeyOnlyRewards(t *testing.T) {
 
 func TestRewardUnitThreshold(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	r := require.New(fixtures.SynchronizedTest(t))
@@ -308,6 +311,7 @@ var defaultPoolAddr = basics.Address{0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0
 
 func TestRewardRateRecalculation(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	r := require.New(fixtures.SynchronizedTest(t))

test/e2e-go/features/partitionRecovery/partitionRecovery_test.go

@@ -32,6 +32,7 @@ const inducePartitionTime = 6 * time.Second    // Try to minimize change of proc
 
 func TestBasicPartitionRecovery(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()
@@ -78,6 +79,7 @@ func TestBasicPartitionRecovery(t *testing.T) {
 
 func TestPartitionRecoverySwapStartup(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()
@@ -100,6 +102,7 @@ func TestPartitionRecoverySwapStartup(t *testing.T) {
 
 func TestPartitionRecoveryStaggerRestart(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()
@@ -167,6 +170,7 @@ func runTestWithStaggeredStopStart(t *testing.T, fixture *fixtures.RestClientFix
 
 func TestBasicPartitionRecoveryPartOffline(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()
@@ -224,6 +228,7 @@ func TestBasicPartitionRecoveryPartOffline(t *testing.T) {
 
 func TestPartitionHalfOffline(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()

test/e2e-go/features/teal/compile_test.go

@@ -30,6 +30,7 @@ import (
 
 func TestTealCompile(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()

test/e2e-go/features/transactions/accountv2_test.go

@@ -77,6 +77,7 @@ func checkEvalDelta(t *testing.T, client *libgoal.Client, startRnd, endRnd uint6
 
 func TestAccountInformationV2(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))

test/e2e-go/features/transactions/app_pages_test.go

@@ -33,6 +33,7 @@ import (
 
 func TestExtraProgramPages(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))

test/e2e-go/features/transactions/application_test.go

@@ -46,6 +46,7 @@ func checkEqual(expected []string, actual []string) bool {
 
 func TestApplication(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))

test/e2e-go/features/transactions/asset_test.go

@@ -55,6 +55,7 @@ func helperFillSignBroadcast(client libgoal.Client, wh []byte, sender string, tx
 
 func TestAssetValidRounds(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))
@@ -188,6 +189,7 @@ func TestAssetValidRounds(t *testing.T) {
 
 func TestAssetConfig(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()
@@ -425,6 +427,7 @@ func TestAssetConfig(t *testing.T) {
 
 func TestAssetInformation(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))
@@ -519,6 +522,7 @@ func TestAssetInformation(t *testing.T) {
 
 func TestAssetGroupCreateSendDestroy(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))
@@ -662,6 +666,7 @@ func TestAssetGroupCreateSendDestroy(t *testing.T) {
 
 func TestAssetSend(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))
@@ -911,6 +916,7 @@ func TestAssetSend(t *testing.T) {
 
 func TestAssetCreateWaitRestartDelete(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	a, fixture, client, account0 := setupTestAndNetwork(t, "", nil)
 	defer fixture.Shutdown()
@@ -974,6 +980,7 @@ func TestAssetCreateWaitRestartDelete(t *testing.T) {
 
 func TestAssetCreateWaitBalLookbackDelete(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	if testing.Short() {
 		t.Skip()

test/e2e-go/features/transactions/close_account_test.go

@@ -28,6 +28,7 @@ import (
 
 func TestAccountsCanClose(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))

test/e2e-go/features/transactions/group_test.go

@@ -32,6 +32,7 @@ import (
 
 func TestGroupTransactions(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))
@@ -104,6 +105,7 @@ func TestGroupTransactions(t *testing.T) {
 
 func TestGroupTransactionsDifferentSizes(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))
@@ -212,6 +214,7 @@ func TestGroupTransactionsDifferentSizes(t *testing.T) {
 
 func TestGroupTransactionsSubmission(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	defer fixtures.ShutdownSynchronizedTest(t)
 
 	t.Parallel()
 	a := require.New(fixtures.SynchronizedTest(t))