txnsync: bloom filter refactoring #2834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/txnsync #2834 +/- ##
===================================================
- Coverage 43.35% 43.34% -0.01%
===================================================
Files 374 374
Lines 84636 84616 -20
===================================================
- Hits 36695 36681 -14
+ Misses 42139 42131 -8
- Partials 5802 5804 +2
Continue to review full report at Codecov.
|
tsachiherman
changed the title
algonautshant
approved these changes
Sep 5, 2021
Contributor
algonautshant
left a comment
algonautshant
left a comment
There was a problem hiding this comment.
Looks great.
A few minor comments.
txnsync/bloomFilter_test.go
Outdated
| testableBf, err := decodeBloomFilter(enc) | ||
| require.NoError(t, err) | ||
| for _, tx := range txnGroups { | ||
| ans := testableBf.test(tx.GroupTransactionID) |
Contributor
There was a problem hiding this comment.
Why is the Modulator variations dropped here?
test checks the modulator value.
Contributor
Author
There was a problem hiding this comment.
good point. I'll add that back. ( i.e. I think that we don't need this for the encoding part.. but we want to verify the testing )
algonautshant
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the bloom filter implementation to have two "implementations" :
testableBloomFilterandbloomFilter.testableBloomFilteris used exclusively when being received from the network; it does not contain any encodedfields, nor does it include
transactionsRangewhich is used for generating new bloom filters.bloomFilteron the flip side is used only for outgoing bloom filters. It doesn't supporttesting, and it contains only the encoded bloom filter ( and not the underlying bloom filter needed for testing, for instance ).This separation allows us to ensure we don't store bloom filter object beyond the required scope, improving the memory utilization.
Test Plan
This PR does not introduce any new functionality. The existing unit tests were updated to use the updated constructs.