Skip to content

Conversation

@algobarb
Copy link
Contributor

Summary

Codegen verification step is now being run by CircleCI, so it's no longer necessary to run it on Travis, especially since we recently got a toomanyrequests: You have reached your pull rate limit. docker error. We want to reduce unnecessary docker requests.

Test Plan

Will check the PR tests to make sure codegen is no longer run on Travis tests.

@algobarb algobarb self-assigned this Aug 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #2768 (d08150e) into master (d7e9240) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2768   +/-   ##
=======================================
  Coverage   47.08%   47.08%           
=======================================
  Files         349      349           
  Lines       56348    56348           
=======================================
+ Hits        26529    26530    +1     
  Misses      26843    26843           
+ Partials     2976     2975    -1     
Impacted Files Coverage Δ
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
cmd/tealdbg/debugger.go 72.86% <0.00%> (-1.01%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
network/wsPeer.go 74.65% <0.00%> (+0.27%) ⬆️
ledger/acctupdates.go 62.63% <0.00%> (+0.50%) ⬆️
catchup/service.go 70.12% <0.00%> (+0.77%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e9240...d08150e. Read the comment docs.

@algobarb algobarb marked this pull request as ready for review August 18, 2021 20:39
Copy link
Contributor

@egieseke egieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tsachiherman tsachiherman merged commit c99b5be into algorand:master Aug 18, 2021
@algobarb algobarb deleted the barbara/rmtraviscodegen branch August 18, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants