Fix TestRekeyUpgrade test #2742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The test checks rekeying before and after upgrade but nodes running as separate processes might upgrade earlier than the test advances * This fix takes this into account similarly to the app upgrade tests
Codecov Report
@@ Coverage Diff @@
## master #2742 +/- ##
==========================================
- Coverage 47.10% 47.10% -0.01%
==========================================
Files 349 349
Lines 56321 56321
==========================================
- Hits 26529 26528 -1
Misses 26819 26819
- Partials 2973 2974 +1
Continue to review full report at Codecov.
|
| // if we had no error it must mean that we've upgraded already. Verify that. | ||
| curStatus, err := client.Status() | ||
| a.NoError(err) | ||
| a.NotEqual(consensusTestUnupgradedProtocol, protocol.ConsensusVersion(curStatus.LastVersion)) |
Contributor
There was a problem hiding this comment.
If this is true, the subsequent test should be skipped, and you could skip ahead to the point where we don't need to wait for the upgrade.
Contributor
Author
There was a problem hiding this comment.
I agree but I found keeping the test logic sequential is better for readability than deep nested logic or goto.
tsachiherman
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
as separate processes might upgrade earlier than the test advances
Test Plan
This is a test