Skip to content

Conversation

@algorandskiy
Copy link
Contributor

Summary

The problem was in commitSyncer goroutine that triggered commitRound in additional to controlled commitRound calls.
Fixed by closing deferred commits channel and waiting commitSyncer to exit.

Test Plan

Checked with -count 1000

* The problem was in commitSyncer goroutine that triggered commitRound
* Checked with -count 1000
@algorandskiy algorandskiy force-pushed the pavel/ledger-test-fix branch from 4b11dca to 69cb3f4 Compare August 6, 2021 21:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #2709 (69cb3f4) into master (39be0c7) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2709      +/-   ##
==========================================
+ Coverage   47.07%   47.08%   +0.01%     
==========================================
  Files         349      349              
  Lines       55858    55858              
==========================================
+ Hits        26294    26301       +7     
+ Misses      26617    26611       -6     
+ Partials     2947     2946       -1     
Impacted Files Coverage Δ
ledger/acctupdates.go 62.71% <50.00%> (+0.41%) ⬆️
ledger/blockqueue.go 83.90% <0.00%> (-1.15%) ⬇️
data/transactions/verify/txn.go 48.45% <0.00%> (ø)
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39be0c7...69cb3f4. Read the comment docs.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tsachiherman tsachiherman merged commit 16bada1 into algorand:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants