testing: replace the KMD usage in pingpong with direct signing #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
+ Coverage 47.07% 47.08% +0.01%
==========================================
Files 349 349
Lines 55858 55858
==========================================
+ Hits 26294 26301 +7
+ Misses 26617 26609 -8
- Partials 2947 2948 +1
Continue to review full report at Codecov.
|
tsachiherman
changed the title
AlgoStephenAkiki
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The changes here replaces the KMD signing with direct signing, which improves the performance.
It also add a unique note to every transaction in order to avoid duplicate transactions.
Test Plan
Pingpong was manually tested.