Remove components.NodeContext, node.nodeContext and unused test implementations #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I was under the impression that it's being used by some of the rest endpoint testing, but maybe it was used in the past and no longer needed. |
winder
approved these changes
Aug 2, 2021
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
Looks like it was used by some agreement tests at one point: https://github.com/algorand/go-algorand-archive/commit/1414aa952804858bf5a9500ac1fdffccb791deb7#
Looking at simulate.go, I wasn't able to find where this code stopped being used... it seems to have disappeared somewhere between go-algorand-archive and go-algorand... but if deleting it doesn't break any tests, lets delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spotted this dead code, and after discussing with @tsachiherman and @zeldovich, it should be fine to remove.
Test Plan
Existing tests should pass.