Skip to content

Conversation

@AlgoStephenAkiki
Copy link
Contributor

@AlgoStephenAkiki AlgoStephenAkiki commented Jul 30, 2021

Resolves #2593

Creates new participation key interface REST endpoints for participation keys.

Summary

Test Plan

@AlgoStephenAkiki AlgoStephenAkiki changed the base branch from master to feature/partkey July 30, 2021 18:11
@AlgoStephenAkiki AlgoStephenAkiki changed the title Temp Create New Participation Key Interface REST endpoints Jul 30, 2021
@AlgoStephenAkiki AlgoStephenAkiki linked an issue Jul 30, 2021 that may be closed by this pull request
@AlgoStephenAkiki AlgoStephenAkiki requested a review from winder July 30, 2021 18:12
@AlgoStephenAkiki AlgoStephenAkiki marked this pull request as ready for review July 30, 2021 18:13
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple of nits

@algorandskiy
Copy link
Contributor

Shouldn't we keep existing register-participation-keys endpoint since it is general available?

@winder
Copy link
Contributor

winder commented Aug 2, 2021

Shouldn't we keep existing register-participation-keys endpoint since it is general available?

I'm not sure. Since it was never implemented I wouldn't feel bad removing/renaming it, but technically you could consider it a breaking change.

@AlgoStephenAkiki
Copy link
Contributor Author

Shouldn't we keep existing register-participation-keys endpoint since it is general available?

I'm not sure. Since it was never implemented I wouldn't feel bad removing/renaming it, but technically you could consider it a breaking change.

I've added back the register-partcipation-keys endpoint.

@algorandskiy
Copy link
Contributor

I'm not sure. Since it was never implemented I wouldn't feel bad removing/renaming it, but technically you could consider it a breaking change.

I did not notice it was not implemented. If so we can drop it indeed, no questions.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #2671 (4666e91) into feature/partkey (2a36601) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feature/partkey    #2671      +/-   ##
===================================================
- Coverage            47.05%   47.02%   -0.03%     
===================================================
  Files                  349      349              
  Lines                55833    55837       +4     
===================================================
- Hits                 26271    26260      -11     
- Misses               26613    26626      +13     
- Partials              2949     2951       +2     
Impacted Files Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
catchup/service.go 68.57% <0.00%> (-1.56%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
network/wsPeer.go 74.37% <0.00%> (-0.84%) ⬇️
ledger/acctupdates.go 61.88% <0.00%> (-0.42%) ⬇️
network/wsNetwork.go 60.92% <0.00%> (ø)
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
ledger/blockqueue.go 83.90% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a36601...4666e91. Read the comment docs.

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should remove /v2/register-participation-keys/{address} and /v2/shutdown but no need to do that here.

@winder winder merged commit 7954ddf into algorand:feature/partkey Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create New Participation Key Interface REST endpoints

4 participants