-
Notifications
You must be signed in to change notification settings - Fork 523
Create New Participation Key Interface REST endpoints #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create New Participation Key Interface REST endpoints #2671
Conversation
winder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a couple of nits
|
Shouldn't we keep existing |
I'm not sure. Since it was never implemented I wouldn't feel bad removing/renaming it, but technically you could consider it a breaking change. |
I've added back the |
I did not notice it was not implemented. If so we can drop it indeed, no questions. |
Codecov Report
@@ Coverage Diff @@
## feature/partkey #2671 +/- ##
===================================================
- Coverage 47.05% 47.02% -0.03%
===================================================
Files 349 349
Lines 55833 55837 +4
===================================================
- Hits 26271 26260 -11
- Misses 26613 26626 +13
- Partials 2949 2951 +2
Continue to review full report at Codecov.
|
winder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We should remove /v2/register-participation-keys/{address} and /v2/shutdown but no need to do that here.
Resolves #2593
Creates new participation key interface REST endpoints for participation keys.
Summary
Test Plan