go-algorand 2.8.0-stable

.circleci/config.yml

@@ -0,0 +1,8 @@
+version: 2.1
+orbs:
+  welcome: circleci/welcome-orb@0.4.1
+workflows:
+  welcome:
+    jobs:
+      - welcome/run
+

.github/ISSUE_TEMPLATE/algorand-engineering-team-issue-template.md

@@ -8,11 +8,14 @@ assignees: ''
 
 ---
 
-## Summary
-<!-- *Describe the problem identified or the general goal of this issue* -->
+## Problem
+<!-- What is the problem that we’re trying to solve? -->
 
-## Scope/Requirements
-<!-- *What's involved in this issue? What's required to achieve the goal?* -->
+## Solution
+<!-- Do you have a potential/suggested solution? Document more than one if possible. -->
 
-## Urgency/Relative Priority
-<!-- *How urgent is this issue? What are the timing considerations to take into account?* -->
+## Dependencies
+<!-- Does the solution have any team or design dependencies? -->
+
+## Urgency
+<!-- What is the urgency here and why? -->

.golangci.yml

@@ -0,0 +1,37 @@
+run:
+  timeout: 5m
+  tests: false
+
+linters:
+  enable:
+    - golint
+    - misspell
+    - govet
+
+  disable:
+    - deadcode
+    - errcheck
+    - gosimple
+    - ineffassign
+    - staticcheck
+    - structcheck
+    - unused
+    - varcheck
+
+linters-settings:
+#  govet:
+#    check-shadowing: true
+
+issues:
+  # don't use default exclude rules listed in `golangci-lint run --help`
+  exclude-use-default: false
+
+  exclude-rules:
+    # ignore govet false positive fixed in https://github.com/golang/go/issues/45043
+    - linters:
+        - govet
+      text: "sigchanyzer: misuse of unbuffered os.Signal channel as argument to signal.Notify"
+    # ignore golint false positive fixed in https://github.com/golang/lint/pull/487
+    - linters:
+        - golint
+      text: "exported method (.*).Unwrap` should have comment or be unexported"

.travis.yml

@@ -28,7 +28,7 @@ jobs:
     - stage: build_commit
       os: linux
       script:
-        - travis_retry scripts/travis/build_test.sh
+        - scripts/travis/build_test.sh
 
     - stage: build_pr
       os: linux
@@ -39,12 +39,12 @@ jobs:
       os: linux
       name: Ubuntu AMD64 Build
       script:
-        - travis_retry scripts/travis/build_test.sh
+        - scripts/travis/build_test.sh
     - # same stage, parallel job
       os: linux
       name: Ubuntu AMD64 Integration Test
       script:
-        - travis_retry ./scripts/travis/integration_test.sh
+        - ./scripts/travis/integration_test.sh
     - # same stage, parallel job
       name: External ARM64 Build
       os: linux
@@ -56,7 +56,7 @@ jobs:
           packages:
             - awscli
       script:
-        - travis_retry scripts/travis/external_build.sh ./scripts/travis/build_test.sh
+        - scripts/travis/external_build.sh ./scripts/travis/build_test.sh
     - # same stage, parallel job
       name: External ARM64 Integration Test
       os: linux
@@ -74,13 +74,13 @@ jobs:
       osx_image: xcode11
       name: MacOS AMD64 Build
       script:
-        - travis_retry scripts/travis/build_test.sh
+        - scripts/travis/build_test.sh
     - # same stage, parallel job
       os: osx
       osx_image: xcode11
       name: MacOS AMD64 Integration Test
       script:
-        - travis_retry ./scripts/travis/integration_test.sh
+        - ./scripts/travis/integration_test.sh
     - # same stage, parallel job
        os: windows
        name: Windows x64 Build
@@ -89,7 +89,7 @@ jobs:
            - $HOME/AppData/Local/Temp/chocolatey
            - /C/tools/msys64
        script:
-         - travis_retry $mingw64 scripts/travis/build_test.sh
+         - $mingw64 scripts/travis/build_test.sh
 
     - stage: build_release
       os: linux
@@ -100,12 +100,12 @@ jobs:
       os: linux
       name: Ubuntu AMD64 Build
       script:
-        - travis_retry ./scripts/travis/build_test.sh
+        - ./scripts/travis/build_test.sh
     - # same stage, parallel job
       os: linux
       name: Ubuntu AMD64 Integration Test
       script:
-        - travis_retry ./scripts/travis/integration_test.sh
+        - ./scripts/travis/integration_test.sh
     - # same stage, parallel job
       name: External ARM64 Build
       os: linux
@@ -117,7 +117,7 @@ jobs:
           packages:
             - awscli
       script:
-        - travis_retry scripts/travis/external_build.sh ./scripts/travis/build_test.sh
+        - scripts/travis/external_build.sh ./scripts/travis/build_test.sh
     - # same stage, parallel job
       name: External ARM64 Integration Test
       os: linux
@@ -135,13 +135,13 @@ jobs:
       osx_image: xcode11
       name: MacOS AMD64 Build
       script:
-        - travis_retry scripts/travis/build_test.sh
+        - scripts/travis/build_test.sh
     - # same stage, parallel job
       os: osx
       osx_image: xcode11
       name: MacOS AMD64 Integration Test
       script:
-        - travis_retry ./scripts/travis/integration_test.sh
+        - ./scripts/travis/integration_test.sh
     - # same stage, parallel job
        os: windows
        name: Windows x64 Build
@@ -150,7 +150,7 @@ jobs:
            - $HOME/AppData/Local/Temp/chocolatey
            - /C/tools/msys64
        script:
-         - travis_retry $mingw64 scripts/travis/build_test.sh
+         - $mingw64 scripts/travis/build_test.sh
 
     - stage: deploy
       name: Ubuntu Deploy
@@ -236,8 +236,10 @@ addons:
 
 notifications:
   slack:
-    secure: lBomhenfQvDzpUGxLadga188zavtGRr05GVWI6iI8ll/uwXewij8ginQ716Axg3pJvvRMNCuTNEmg0+fVlHf0JxTG3qWG35qOUexAHGcmimPD4ugmVkufua8Oc8Nl1LRSdWvbwIKvrAU1HDA37M5tCdEOm+Sf/OL72iVWbXhlHRvhdeiKHkbkcpI/15dOH4RpXuvPeYBrgcB2Ixs7gTSVyIAU458aT0JORu7expElQ+iBP9Kqze1V4dvjJyzHTgE01z2nyAm2Xpko447y//fYX2e20iDBE5S/GukaK/TeB3pD+FoC+Z2R7Gg1qA7a/gdGFbVgP12zWmzNaKVwY1YOvx8IIwP13XutioAE7bQbnHI1zGlQ+jxk3odWKZPhZSN/YvWD3i7g/xVksaTo++zwon2UlZ7x8LmKg1kOMeA3o2TUlzjQrwZZ4cB+4HqYHEqVdsSAadaMhKK82XE1OtGImdrIX1Y/02X2F/myJXwaE4Ap8smULHWGghCL/ALad+hdyE0K4/2SYDcoaOONgX9+VgaSEtYDO00Bt4/GMcuM+gwILsfCA9ZQuxCgIFEL1QWwDud8aGU1qF20yaimDlstlLnZXsv3Oli6r/CEEUVXltI5dkJyRd/jTlqWGjFGL8agGg34EPLP24Vn4h4QcIzoMfGWXkz2yrd6i0fvMAPXds=
+    if: branch = "rel/nightly"
+    rooms:
+      - secure: jx2gllL8A8QXkV/wVpfKBRfK7cMQkuHOxxFmN2eYEGR8AR6bAGfo5HVmb6VKBRpwVzOgXwhvjbxNdYlmRkKXeJ5o0DDDUG6YSKIrNkA38JulNKzdG3K3d6DoGJV3Iturp6O9W/IdweRSz2rjJsHP1RpYG3w39giSNTMR/Q4ent68CNoYHC3XEsUHmwGVA8bQpfu2AKfr98twgTzmTcvmx93B/ZHlR8GoLh+Vq2eAwiYuyYnoNYww3ekttqeqAr21X5xTjQyAwntnk1gfRKbdiEXcxlnNKCQn3yaD7qNorJZm9U/fhGiA1eLHOxtLLJD8HSEzLvNj9gShgw/YPaYjZJLZJe0kDpR4oFwVd+lVzBManVGOwfHJIsug8dnVxY1O/PLHPV4iM4tyGwcZfxSLOXsutN3PCJhYjKUrKaJ75+L5d1tXe3DoXtGH5e/GV2kGxWr25woAZrKCeBOPFZdhAc30XLOzTk3FN3hzRKVbL9O4zxFgJllOvQTWDQ9bmXxa3bk6cDwxaF8IJk+hP1k3VaOdaxmd28pnyR/X7xRF0l1W8S6SZfDFXAFBvVyH/Q1nfvXAez//cK0He959reubjUGM8HaSWw73n9Bj5Ri4ub92xfJqSAZItI5dS1hjfdh7moS50dYbBwSozgOgWdFXHdzGNnCv+/8v0LJcnSPRdT8=
+
 env:
   global:
     secure: YMLx+QaBPgg97tVn2efZJSqwPRxybX9oR6Xe9oXUD4fEiVbOIv2BAsLP+MzSJGaFC+VXKha83kyDbAZnatDXTJYsBPOUgmIZDObQnktueR1v3TCKn3aw14G+/w6S4eQL+c7uW3idPE+KP3VWixjrBpWTHEfnZdnH9+qWeIWzy8A8UEAYPY/HXyDmwt5ceCJoITtdsuiuZNO2o7NGN8q+NP5A3ii8f5UyDa9/krxuA+x1e193wSGRdGcqxexM7zIq0uMhBF+2nOk4RAsDsqU33NpQw+dB1VJMta1XF+P6A7m16UKUjllTyOfUPGD068jKobVyWzbvZ79G2FZXGZ7HGE0711JZco3YenwtxXP8oGLgaIds6McoJnn3rbxe1i+PjRX09IXNQM/dNp53uxrtyi1y8ZEjzHjbb6z3rSOZrzaBhdVxBFR9Oc1Ek7i8MS1tlRlH58+U+Z1WPTvbcIQtFA5HmmTcDdBRkZtPC8bpVLHOZTGUcple9k39VtOGuSCvAAfHKENhieCaw/bBXX4bxAHAfiI0NEmdDrULDJLApWjtRCrUIqIqkdsJmtiZhE+iX1FKR9CP5lBXCAwDlPB3XOe0bSmiiGQ1/sf/1CovqOBg/vLwCpjQE0IZPofCiDZZdZbv4n4aCOjiAqhS8MjJ/LfLyUuAtPmQG5g47FzS1K4=
-

README.md

@@ -10,7 +10,7 @@ decentralization, scalability, security, and transaction finality.
 ## Getting Started ##
 
 Our [developer website][developer site url] has the most up to date information
-about using and installing the algorand platform.
+about using and installing the Algorand platform.
 
 ## Building from source ##
 
@@ -21,7 +21,7 @@ the [official Go documentation website](https://golang.org/doc/).
 
 ### Linux / OSX ###
 
-We currently strive to support Debian based distributions with Ubuntu 18.04
+We currently strive to support Debian-based distributions with Ubuntu 18.04
 being our official release target.
 Building on Arch Linux works as well.
 Our core engineering team uses Linux and OSX, so both environments are well
@@ -39,7 +39,7 @@ cd go-algorand
 ./scripts/buildtools/install_buildtools.sh
 ```
 
-At this point you are ready to build go-algorand. We use `make` and have a
+At this point, you are ready to build go-algorand. We use `make` and have a
 number of targets to automate common tasks.
 
 #### build
@@ -108,17 +108,17 @@ daemons, as well as other tools and commands:
     locally by the node as well as parameters which must be agreed upon by the
     protocol.
   - `data` defines various types used throughout the codebase.
-     - `basics` holds basic types such as MicroAlgos, account data, and
+     - `basics` hold basic types such as MicroAlgos, account data, and
        addresses.
      - `account` defines accounts, including "root" accounts (which can
        spend money) and "participation" accounts (which can participate in
        the agreement protocol).
-     - `transactions` defines transactions that accounts can issue against
+     - `transactions` define transactions that accounts can issue against
        the Algorand state.  These include standard payments and also
        participation key registration transactions.
      - `bookkeeping` defines blocks, which are batches of transactions
        atomically committed to Algorand.
-     - `pools` implements the transaction pool.  The transaction pool holds
+     - `pools` implement the transaction pool.  The transaction pool holds
        transactions seen by a node in memory before they are proposed in a
        block.
      - `committee` implements the credentials that authenticate a
@@ -132,7 +132,7 @@ daemons, as well as other tools and commands:
     routing network messages, and prefixes for domain separation of
     cryptographic inputs.  It also implements the canonical encoder.
   - `network` contains the code for participating in a mesh network based on
-    websockets. Maintains connection to some number of peers, (optionally)
+    WebSockets. Maintains connection to some number of peers, (optionally)
     accepts connections from peers, sends point to point and broadcast messages,
     and receives messages routing them to various handler code
     (e.g. agreement/gossip/network.go registers three handlers).
@@ -179,7 +179,7 @@ of their own:
 A number of packages provide utilities for the various components:
 
   - `logging` is a wrapper around `logrus`.
-  - `util` contains a variety of utilities, including a codec, a sqlite wrapper,
+  - `util` contains a variety of utilities, including a codec, a SQLite wrapper,
     a goroutine pool, a timer interface, node metrics, and more.
 
 `test` ([README](test/README.md)) contains end-to-end tests and utilities for the above components.

agreement/abstractions.go

@@ -51,7 +51,7 @@ type BlockValidator interface {
 	Validate(context.Context, bookkeeping.Block) (ValidatedBlock, error)
 }
 
-// A ValidatedBlock represents an Block that has been successfuly validated
+// A ValidatedBlock represents an Block that has been successfully validated
 // and can now be recorded in the ledger.  This is an optimized version of
 // calling EnsureBlock() on the Ledger.
 type ValidatedBlock interface {

agreement/fuzzer/fuzzer_test.go

@@ -229,7 +229,7 @@ func (n *Fuzzer) initAccountsAndBalances(rootSeed []byte, onlineNodes []bool) er
 	return nil
 }
 
-// Disconnect would disconnect node diconnectingNode from node disconnectedNode ensuring that no futher messages
+// Disconnect would disconnect node diconnectingNode from node disconnectedNode ensuring that no further messages
 // from disconnectedNode would reach diconnectingNode
 func (n *Fuzzer) Disconnect(diconnectingNode, disconnectedNode int) {
 	n.disconnectMu.Lock()

agreement/fuzzer/networkFacade_test.go

@@ -352,7 +352,7 @@ func (n *NetworkFacade) Zero() timers.Clock {
 	n.zeroClock = n.fuzzer.WallClock()
 
 	// we don't want to expire all the pending clocks here.
-	// this callback is coming *only* from the agreement sevice.
+	// this callback is coming *only* from the agreement service.
 	// it also means that we're not in the demux loop, so no one is blocking
 	// on any of the clocks.
 

agreement/fuzzer/tests_test.go

@@ -78,7 +78,7 @@ func printResults(t *testing.T, r *RunResult) {
 		r.PostRecoveryLowRound, r.PostRecoveryHighRound,
 	)
 	if r.PreRecoveryHighRound != r.PreRecoveryLowRound {
-		// network got disupted by the filters.
+		// network got disputed by the filters.
 		fmt.Printf("%v partitioned the network ( %d - %d ), but recovered correctly reaching round %d\n", t.Name(), r.PreRecoveryLowRound, r.PreRecoveryHighRound, r.PostRecoveryHighRound)
 	} else {
 		if r.PreRecoveryHighRound == r.StartLowRound {

agreement/fuzzer/validator_test.go

@@ -82,7 +82,7 @@ func (v *Validator) CheckNetworkRecovery() {
 		v.runResult.PostRecoveryLowRound, v.runResult.PostRecoveryHighRound,
 	)
 	if v.runResult.PreRecoveryHighRound != v.runResult.PreRecoveryLowRound {
-		// network got disupted by the filters.
+		// network got disputed by the filters.
 		fmt.Printf("%v partitioned the network ( %d - %d ), but recovered correctly reaching round %d\n", v.tb.Name(), v.runResult.PreRecoveryLowRound, v.runResult.PreRecoveryHighRound, v.runResult.PostRecoveryHighRound)
 	} else {
 		if v.runResult.PreRecoveryHighRound == v.runResult.StartLowRound {