Use dashes in v2 API. #2569
Merged
Use dashes in v2 API. #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
commented
Jul 16, 2021
| "type": "string" | ||
| }, | ||
| "unit-name_b64": { | ||
| "description": "\\[un64\\] base64 encoded name of a unit of this asset, as supplied by the creator.", |
Contributor
Author
There was a problem hiding this comment.
The square brackets document the message pack name, so they aren't needed for these.
Codecov Report
@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
+ Coverage 46.87% 46.90% +0.02%
==========================================
Files 346 346
Lines 55668 55668
==========================================
+ Hits 26094 26110 +16
+ Misses 26619 26608 -11
+ Partials 2955 2950 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use dashes to match the v2 API convention.
Test Plan
N/A