Skip to content

Conversation

@tsachiherman
Copy link
Contributor

Summary

lookup in no-GOPATH locations for packages in gocodec testing; The existing code is trying to use the GOPATH as the base for the packages directories, however, this might not be the case when tests are being executed on travis.

Test Plan

This is a test.

@codecov-commenter
Copy link

Codecov Report

Merging #2562 (1d35dfa) into master (01248d2) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
+ Coverage   46.89%   46.92%   +0.03%     
==========================================
  Files         346      346              
  Lines       55616    55630      +14     
==========================================
+ Hits        26081    26106      +25     
+ Misses      26580    26576       -4     
+ Partials     2955     2948       -7     
Impacted Files Coverage Δ
protocol/codec_tester.go 0.00% <0.00%> (ø)
ledger/catchpointwriter.go 68.18% <0.00%> (-1.30%) ⬇️
data/transactions/verify/txn.go 46.39% <0.00%> (-1.04%) ⬇️
ledger/acctupdates.go 61.83% <0.00%> (-0.09%) ⬇️
network/wsNetwork.go 61.02% <0.00%> (+0.28%) ⬆️
ledger/eval.go 76.68% <0.00%> (+0.29%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01248d2...1d35dfa. Read the comment docs.

@tsachiherman tsachiherman requested a review from a user July 15, 2021 20:14
ghost
ghost previously approved these changes Jul 16, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, had an optional nit

@tsachiherman tsachiherman merged commit 6ce65af into algorand:master Jul 16, 2021
@tsachiherman tsachiherman deleted the tsachi/codectesterfix branch July 16, 2021 00:27
@tsachiherman tsachiherman restored the tsachi/codectesterfix branch August 16, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants