Use golangci-lint

.golangci.yml

@@ -0,0 +1,37 @@
+run:
+  timeout: 5m
+  tests: false
+
+linters:
+  enable:
+    - golint
+    - misspell
+    - govet
+
+  disable:
+    - deadcode
+    - errcheck
+    - gosimple
+    - ineffassign
+    - staticcheck
+    - structcheck
+    - unused
+    - varcheck
+
+linters-settings:
+#  govet:
+#    check-shadowing: true
+
+issues:
+  # don't use default exclude rules listed in `golangci-lint run --help`
+  exclude-use-default: false
+
+  exclude-rules:
+    # ignore govet false positive fixed in https://github.com/golang/go/issues/45043
+    - linters:
+        - govet
+      text: "sigchanyzer: misuse of unbuffered os.Signal channel as argument to signal.Notify"
+    # ignore golint false positive fixed in https://github.com/golang/lint/pull/487
+    - linters:
+        - golint
+      text: "exported method (.*).Unwrap` should have comment or be unexported"

ledger/txtail.go

@@ -62,10 +62,10 @@ func (t *txTail) loadFromDisk(l ledgerForTracker) error {
 
 	t.recent = make(map[basics.Round]roundTxMembers)
 
-	// the roundsLastValids is a temporary map used during the exection of
+	// the roundsLastValids is a temporary map used during the execution of
 	// loadFromDisk, allowing us to construct the lastValid maps in their
 	// optimal size. This would ensure that upon startup, we don't preallocate
-	// more memory than we truely need.
+	// more memory than we truly need.
 	roundsLastValids := make(map[basics.Round][]transactions.Txid)
 
 	for ; old <= latest; old++ {

node/node.go

@@ -488,7 +488,7 @@ func (node *AlgorandFullNode) writeDevmodeBlock() (err error) {
 
 // BroadcastSignedTxGroup broadcasts a transaction group that has already been signed.
 func (node *AlgorandFullNode) BroadcastSignedTxGroup(txgroup []transactions.SignedTxn) (err error) {
-	// in developer mode, we need to take a lock, so that each new transaction group would truely
+	// in developer mode, we need to take a lock, so that each new transaction group would truly
 	// render into a unique block.
 	if node.devMode {
 		node.mu.Lock()

nodecontrol/nodeControlErrors.go

@@ -34,6 +34,6 @@ func (e *errAlgodExitedEarly) Error() string {
 	return fmt.Sprintf("node exited with an error code, check node.log for more details : %v", e.innerError)
 }
 
-func (e *errAlgodExitedEarly) Unwrap(err error) error {
+func (e *errAlgodExitedEarly) Unwrap() error {
 	return e.innerError
 }