Specs and unit test to avoid forgetting in the future

data/transactions/logic/TEAL_opcodes.md

@@ -547,7 +547,7 @@ for notes on transaction fields available, see `txn`. If top of stack is _i_, `g
 
 ## gaid t
 
-- Opcode: 0x3c
+- Opcode: 0x3c {uint8 transaction group index}
 - Pops: _None_
 - Pushes: uint64
 - push the ID of the asset or application created in the Tth transaction of the current group
@@ -914,7 +914,7 @@ pushint args are not added to the intcblock during assembly processes
 
 ## callsub target
 
-- Opcode: 0x88
+- Opcode: 0x88 {int16 branch offset, big endian}
 - Pops: _None_
 - Pushes: _None_
 - branch unconditionally to TARGET, saving the next instruction on the call stack

data/transactions/logic/doc.go

@@ -166,10 +166,12 @@ var opcodeImmediateNotes = map[string]string{
 	"bnz":               "{int16 branch offset, big endian}",
 	"bz":                "{int16 branch offset, big endian}",
 	"b":                 "{int16 branch offset, big endian}",
+	"callsub":           "{int16 branch offset, big endian}",
 	"load":              "{uint8 position in scratch space to load from}",
 	"store":             "{uint8 position in scratch space to store to}",
 	"gload":             "{uint8 transaction group index} {uint8 position in scratch space to load from}",
 	"gloads":            "{uint8 position in scratch space to load from}",
+	"gaid":              "{uint8 transaction group index}",
 	"substring":         "{uint8 start position} {uint8 end position}",
 	"dig":               "{uint8 depth}",
 	"asset_holding_get": "{uint8 asset holding field index}",

data/transactions/logic/doc_test.go

@@ -17,6 +17,7 @@
 package logic
 
 import (
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -77,6 +78,19 @@ func TestOpImmediateNote(t *testing.T) {
 	require.Empty(t, xd)
 }
 
+func TestAllImmediatesDocumented(t *testing.T) {
+	for _, op := range OpSpecs {
+		count := len(op.Details.Immediates)
+		note := OpImmediateNote(op.Name)
+		if count == 1 && op.Details.Immediates[0].kind >= immBytes {
+			// More elaborate than can be checked by easy count.
+			require.NotEmpty(t, note)
+			continue
+		}
+		require.Equal(t, count, strings.Count(note, "{"), "%s immediates doc is wrong", op.Name)
+	}
+}
+
 func TestOpDocExtra(t *testing.T) {
 	xd := OpDocExtra("bnz")
 	require.NotEmpty(t, xd)

scripts/travis/codegen_verification.sh

@@ -75,6 +75,9 @@ echo "Running fixcheck"
 GOPATH=$(go env GOPATH)
 "$GOPATH"/bin/algofix -error */
 
+echo "Updating TEAL Specs"
+make -C data/transactions/logic
+
 echo Checking Enlistment...
 if [[ -n $(git status --porcelain) ]]; then
    echo Enlistment is dirty - did you forget to run make?