Skip to content

Fix rel nightly test by extending catchpoint round timeout #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algojohnlee merged 2 commits into from
Jun 4, 2021
Merged

Fix rel nightly test by extending catchpoint round timeout #2240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67ce2a2
Extend catchpoint wait for round timeout from 10 to 60 milliseconds.
egieseke Jun 3, 2021
5ef3b71
Increase timeout for first round from 10 to 60 seconds.
egieseke Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e-go/features/catchup/catchpointCatchup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func TestBasicCatchpointCatchup(t *testing.T) {
targetRound = uint64(1)
log.Infof("Second node catching up to round 1")
for {
err = fixture.ClientWaitForRound(secondNodeRestClient, currentRound, 10000*time.Millisecond)
err = fixture.ClientWaitForRound(secondNodeRestClient, currentRound, 60*time.Second)
Copy link
Contributor

@tsachiherman tsachiherman Jun 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this issue is reproducible, we should figure out why it's happening. Just masking this issue would make the platform less reliable ( i.e. this type of waits would, for example, mask out a 21 second rounds blocks ). Maybe try to conduct a binary search to find where the regression point was ?

Copy link
Contributor

@onetechnical onetechnical Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this. I'm a little worried this is highlighting a bigger issue, especially if it is a consistent failure.

a.NoError(err)
if targetRound <= currentRound {
break
Expand All @@ -220,7 +220,7 @@ func TestBasicCatchpointCatchup(t *testing.T) {
targetRound = uint64(37)
log.Infof("Second node catching up to round 36")
for {
err = fixture.ClientWaitForRound(secondNodeRestClient, currentRound, 10000*time.Millisecond)
err = fixture.ClientWaitForRound(secondNodeRestClient, currentRound, 60*time.Second)
a.NoError(err)
if targetRound <= currentRound {
break
Expand Down