Skip to content

testing: fix TestRekeyUpgrade when round=0 #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 4 commits into from
May 25, 2021
Merged

testing: fix TestRekeyUpgrade when round=0 #2188

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c772be8
Fix TestRekeyUpgrade by handling the round=0 corner case.
tsachiherman May 25, 2021
e669054
apply changes based on peer review feedback.
tsachiherman May 25, 2021
47bac8b
Merge branch 'master' into tsachi/refixrekeyupgradetest
tsachiherman May 25, 2021
5b58f9e
Fix typo
tsachiherman May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 46 additions & 47 deletions test/e2e-go/upgrades/rekey_support_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ import (
"github.com/stretchr/testify/require"

"github.com/algorand/go-algorand/data/basics"
"github.com/algorand/go-algorand/protocol"
"github.com/algorand/go-algorand/test/framework/fixtures"
)

// TestRekeyUpgrade tests that we rekey does not work before the upgrade and works well after
// TestRekeyUpgrade tests that the rekey does not work before the upgrade and works well after
func TestRekeyUpgrade(t *testing.T) {
a := require.New(fixtures.SynchronizedTest(t))

Expand Down Expand Up @@ -63,66 +64,64 @@ func TestRekeyUpgrade(t *testing.T) {
initialStatus := curStatus
round := curStatus.LastRound

if initialStatus.NextVersion != initialStatus.LastVersion {
// no consensus upgrade took place
// no consensus upgrade took place (yet)

// Ensure no rekeying happened
ad, err := client.AccountData(accountA)
a.NoError(err)
a.Equal(basics.Address{}, ad.AuthAddr)
// Ensure no rekeying happened
ad, err := client.AccountData(accountA)
a.NoError(err)
a.Equal(basics.Address{}, ad.AuthAddr)

// rekey A -> B (RekeyTo check)
tx, err := client.ConstructPayment(accountA, accountB, fee, amount, nil, "", lease, basics.Round(round), basics.Round(initialStatus.NextVersionRound).SubSaturate(1))
a.NoError(err)
// rekey A -> B (RekeyTo check)
tx, err := client.ConstructPayment(accountA, accountB, fee, amount, nil, "", lease, basics.Round(round), basics.Round(initialStatus.NextVersionRound).SubSaturate(1))
a.NoError(err)

tx.RekeyTo = addrB
tx.RekeyTo = addrB

rekey, err := client.SignTransactionWithWalletAndSigner(wh, nil, "", tx)
a.NoError(err)
rekey, err := client.SignTransactionWithWalletAndSigner(wh, nil, "", tx)
a.NoError(err)

_, err = client.BroadcastTransaction(rekey)
a.Error(err)
// should be either "transaction has RekeyTo set but rekeying not yet enable" or "txn dead"
if !strings.Contains(err.Error(), "transaction has RekeyTo set but rekeying not yet enable") &&
!strings.Contains(err.Error(), "txn dead") {
a.NoErrorf(err, "error message should be one of :\n%s\n%s", "transaction has RekeyTo set but rekeying not yet enable", "txn dead")
}

// use rekeyed key to authorize (AuthAddr check)
tx.RekeyTo = basics.Address{}
rekeyed, err := client.SignTransactionWithWalletAndSigner(wh, nil, accountB, tx)
a.NoError(err)
_, err = client.BroadcastTransaction(rekeyed)
// should be either "nonempty AuthAddr but rekeying not supported" or "txn dead"
if !strings.Contains(err.Error(), "nonempty AuthAddr but rekeying not supported") &&
!strings.Contains(err.Error(), "txn dead") {
a.NoErrorf(err, "error message should be one of :\n%s\n%s", "nonempty AuthAddr but rekeying not supported", "txn dead")
}

// go to upgrade
curStatus, err = client.Status()
a.NoError(err)
_, err = client.BroadcastTransaction(rekey)
a.Error(err)
// should be either "transaction has RekeyTo set but rekeying not yet enable" or "txn dead"
if !strings.Contains(err.Error(), "transaction has RekeyTo set but rekeying not yet enable") &&
!strings.Contains(err.Error(), "txn dead") {
a.NoErrorf(err, "error message should be one of :\n%s\n%s", "transaction has RekeyTo set but rekeying not yet enable", "txn dead")
}

startLoopTime := time.Now()
// use rekeyed key to authorize (AuthAddr check)
tx.RekeyTo = basics.Address{}
rekeyed, err := client.SignTransactionWithWalletAndSigner(wh, nil, accountB, tx)
a.NoError(err)
_, err = client.BroadcastTransaction(rekeyed)
// should be either "nonempty AuthAddr but rekeying not supported" or "txn dead"
if !strings.Contains(err.Error(), "nonempty AuthAddr but rekeying not supported") &&
!strings.Contains(err.Error(), "txn dead") {
a.NoErrorf(err, "error message should be one of :\n%s\n%s", "nonempty AuthAddr but rekeying not supported", "txn dead")
}

// wait until the network upgrade : this can take a while.
for curStatus.LastVersion == initialStatus.LastVersion {
curStatus, err = client.Status()
a.NoError(err)
// go to upgrade
curStatus, err = client.Status()
a.NoError(err)

a.Less(int64(time.Now().Sub(startLoopTime)), int64(3*time.Minute))
time.Sleep(time.Duration(smallLambdaMs) * time.Millisecond)
round = curStatus.LastRound
}
startLoopTime := time.Now()

// wait until the network upgrade : this can take a while.
for protocol.ConsensusVersion(curStatus.LastVersion) != consensusTestFastUpgrade(firstProtocolWithApplicationSupport) {
curStatus, err = client.Status()
a.NoError(err)

a.Less(int64(time.Now().Sub(startLoopTime)), int64(3*time.Minute))
time.Sleep(time.Duration(smallLambdaMs) * time.Millisecond)
round = curStatus.LastRound
}

// now that the network alrady upgraded:

tx, err := client.ConstructPayment(accountA, accountB, fee, amount, nil, "", lease, basics.Round(round), basics.Round(round+1000))
tx, err = client.ConstructPayment(accountA, accountB, fee, amount, nil, "", lease, basics.Round(round), basics.Round(round+1000))
a.NoError(err)
tx.RekeyTo = addrB

rekey, err := client.SignTransactionWithWalletAndSigner(wh, nil, "", tx)
rekey, err = client.SignTransactionWithWalletAndSigner(wh, nil, "", tx)
a.NoError(err)

// now, that we have upgraded to the new protocol which supports rekey, try again.
Expand All @@ -135,7 +134,7 @@ func TestRekeyUpgrade(t *testing.T) {

// use rekeyed key to authorize (AuthAddr check)
tx.RekeyTo = basics.Address{}
rekeyed, err := client.SignTransactionWithWalletAndSigner(wh, nil, accountB, tx)
rekeyed, err = client.SignTransactionWithWalletAndSigner(wh, nil, accountB, tx)
a.NoError(err)

_, err = client.BroadcastTransaction(rekeyed)
Expand Down