Skip to content

tests: fix rekey upgrade test #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 1 commit into from
May 25, 2021
Merged

tests: fix rekey upgrade test #2178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 64 additions & 33 deletions test/e2e-go/upgrades/rekey_support_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package upgrades

import (
"path/filepath"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -50,55 +51,80 @@ func TestRekeyUpgrade(t *testing.T) {
accountB, err := client.GenerateAddress(wh)
a.NoError(err)

round, err := client.CurrentRound()
a.NoError(err)

// Ensure no rekeying happened
ad, err := client.AccountData(accountA)
addrB, err := basics.UnmarshalChecksumAddress(accountB)
a.NoError(err)
a.Equal(basics.Address{}, ad.AuthAddr)

// rekey A -> B (RekeyTo check)
fee := uint64(1000)
amount := uint64(1000000)
lease := [32]byte{}
tx, err := client.ConstructPayment(accountA, accountB, fee, amount, nil, "", lease, basics.Round(round), basics.Round(round+1000))
a.NoError(err)

addrB, err := basics.UnmarshalChecksumAddress(accountB)
a.NoError(err)
tx.RekeyTo = addrB

rekey, err := client.SignTransactionWithWalletAndSigner(wh, nil, "", tx)
a.NoError(err)
_, err = client.BroadcastTransaction(rekey)
a.Error(err)
a.Contains(err.Error(), "transaction has RekeyTo set but rekeying not yet enable")

// use rekeyed key to authorize (AuthAddr check)
tx.RekeyTo = basics.Address{}
rekeyed, err := client.SignTransactionWithWalletAndSigner(wh, nil, accountB, tx)
a.NoError(err)
_, err = client.BroadcastTransaction(rekeyed)
a.Error(err)
a.Contains(err.Error(), "nonempty AuthAddr but rekeying not supported")
// go to upgrade
curStatus, err := client.Status()
a.NoError(err)
initialStatus := curStatus
round := curStatus.LastRound

startLoopTime := time.Now()
if initialStatus.NextVersion != initialStatus.LastVersion {
// no consensus upgrade took place

// wait until the network upgrade : this can take a while.
for curStatus.LastVersion == initialStatus.LastVersion {
// Ensure no rekeying happened
ad, err := client.AccountData(accountA)
a.NoError(err)
a.Equal(basics.Address{}, ad.AuthAddr)

// rekey A -> B (RekeyTo check)
tx, err := client.ConstructPayment(accountA, accountB, fee, amount, nil, "", lease, basics.Round(round), basics.Round(initialStatus.NextVersionRound).SubSaturate(1))
a.NoError(err)

tx.RekeyTo = addrB

rekey, err := client.SignTransactionWithWalletAndSigner(wh, nil, "", tx)
a.NoError(err)

_, err = client.BroadcastTransaction(rekey)
a.Error(err)
// should be either "transaction has RekeyTo set but rekeying not yet enable" or "txn dead"
if !strings.Contains(err.Error(), "transaction has RekeyTo set but rekeying not yet enable") &&
!strings.Contains(err.Error(), "txn dead") {
a.NoErrorf(err, "error message should be one of :\n%s\n%s", "transaction has RekeyTo set but rekeying not yet enable", "txn dead")
}

// use rekeyed key to authorize (AuthAddr check)
tx.RekeyTo = basics.Address{}
rekeyed, err := client.SignTransactionWithWalletAndSigner(wh, nil, accountB, tx)
a.NoError(err)
_, err = client.BroadcastTransaction(rekeyed)
// should be either "nonempty AuthAddr but rekeying not supported" or "txn dead"
if !strings.Contains(err.Error(), "nonempty AuthAddr but rekeying not supported") &&
!strings.Contains(err.Error(), "txn dead") {
a.NoErrorf(err, "error message should be one of :\n%s\n%s", "nonempty AuthAddr but rekeying not supported", "txn dead")
}

// go to upgrade
curStatus, err = client.Status()
a.NoError(err)

a.Less(int64(time.Now().Sub(startLoopTime)), int64(3*time.Minute))
time.Sleep(time.Duration(smallLambdaMs) * time.Millisecond)
round = curStatus.LastRound
startLoopTime := time.Now()

// wait until the network upgrade : this can take a while.
for curStatus.LastVersion == initialStatus.LastVersion {
curStatus, err = client.Status()
a.NoError(err)

a.Less(int64(time.Now().Sub(startLoopTime)), int64(3*time.Minute))
time.Sleep(time.Duration(smallLambdaMs) * time.Millisecond)
round = curStatus.LastRound
}
}

// now that the network alrady upgraded:

tx, err := client.ConstructPayment(accountA, accountB, fee, amount, nil, "", lease, basics.Round(round), basics.Round(round+1000))
a.NoError(err)
tx.RekeyTo = addrB

rekey, err := client.SignTransactionWithWalletAndSigner(wh, nil, "", tx)
a.NoError(err)

// now, that we have upgraded to the new protocol which supports rekey, try again.
_, err = client.BroadcastTransaction(rekey)
a.NoError(err)
Expand All @@ -107,6 +133,11 @@ func TestRekeyUpgrade(t *testing.T) {
a.NoError(err)
client.WaitForRound(round + 1)

// use rekeyed key to authorize (AuthAddr check)
tx.RekeyTo = basics.Address{}
rekeyed, err := client.SignTransactionWithWalletAndSigner(wh, nil, accountB, tx)
a.NoError(err)

_, err = client.BroadcastTransaction(rekeyed)
a.NoError(err)
}