testing: improve e2e protocol upgrade tests #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
changed the title
algonautshant
approved these changes
May 22, 2021
| a.NoError(err) | ||
|
|
||
| time.Sleep(time.Second) | ||
| pongWalletHandle, err = pongClient.GetUnencryptedWalletHandle() |
Contributor
There was a problem hiding this comment.
why this needs to be called at each iteration?
Contributor
Author
There was a problem hiding this comment.
The handle would expire after a while.. so it need to be refreshed frequently. I could have added a error-handling for that and refresh the handle only when needed, but I figured out that this would likely to be an overkill for this scenario.
tsachiherman
added a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
This PR addresses a bug in the protocol upgrade tests where the `AgreementFilterTimeout` was not set correctly. In addition, this test removes `SendPaymentFromUnencryptedWallet()` and replaces it with separate `SendPaymentFromWallet()` and `GetUnencryptedWalletHandle()` calls for higher efficiency. Last, this change *disables* the tests parallelism. Running the upgrade tests in parallel seems to be slower overall. This is still pending investigation, but can be decoupled from these changes for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a bug in the protocol upgrade tests where the
AgreementFilterTimeoutwas not set correctly.In addition, this test removes
SendPaymentFromUnencryptedWallet()and replaces it with separateSendPaymentFromWallet()andGetUnencryptedWalletHandle()calls for higher efficiency.Last, this change disables the tests parallelism. Running the upgrade tests in parallel seems to be slower overall. This is still pending investigation, but can be decoupled from these changes for now.
Test Plan
This is a test.