bugfix: ensure stopping a node always stops kmd #2169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
changed the title
algonautshant
approved these changes
May 20, 2021
| errAlgod := nc.StopAlgod() | ||
| kmdAlreadyStopped, err = nc.StopKMD() | ||
| if errAlgod != nil { | ||
| err = errAlgod |
Contributor
There was a problem hiding this comment.
Looks like we are ignoring the kmd error if algod has an error.
Maybe this if fine.
Contributor
Author
There was a problem hiding this comment.
I think that using a composite error here would only be more complicated, and not really that more useful.
tsachiherman
added a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
Existing implementation was not stopping the KMD in case we have failed to stop `algod`. This is wrong. A call to `NodeController.FullStop` should stop both of them, and return an error if it's unable to do so. The concrete use case here was that algod has crashed while kmd remained in memory. Calling the above `FullStop()` failed since the `algod` was already gone, and therefore would not attempt to stop `kmd`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Existing implementation was not stopping the KMD in case we have failed to stop
algod. This is wrong. A call toNodeController.FullStopshould stop both of them, and return an error if it's unable to do so.The concrete use case here was that algod has crashed while kmd remained in memory. Calling the above
FullStop()failed since thealgodwas already gone, and therefore would not attempt to stopkmd.Test Plan
This issue was uncovered by the expect node test.