Rebase transaction sync with master #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e agreement is running ahead of the ledger.
Provide a fallback to use the default consensus parameters in case the agreement is running ahead of the ledger.
Most of the new TEAL 3 features already work with the debugger, but a few changes were needed to make the new array fields display properly on the Chrome frontend.
expand unit test
tealdbg: listen on specified address
e2e test runner : skip printing the logs when program is in terminated state.
Based on review comments, pushing down these for more fine tuned configuration and to eliminate the reuse of the fetcher.
The functions are removed, and all supporting fields. Tests that relied on them are updated to use alternative means for wating whenever necessary.
…duration computation.
…etcher Use the peer selector as part of the catchup service implementation in order to support archiver nodes.
I discovered that algorand#1004 accidentally changed the `total-transactions` field in the `getPendingTransactions` handler function. That value is supposed to be the total number of pending transactions, but currently it is only the number of transactions returned by the current API call. I've fixed this and improved the names of local variables to make this easier to see. While testing this, I also discovered a bug with the `max` parameter. When set to 0, `getPendingTransactions` should return all pending transactions. The current behavior is correct when there is no `max` query param in the API request, but when explicitly setting `max` to 0 (i.e.`/v2/transactions/pending?max=0`) the endpoint always returns 0 transactions. Since the documentation states `If max=0, returns all pending txns`, I believe this is undesirable so I've also fixed this.
Avoid allocation of memory in subsequent calls to Test, and Set.
tsachiherman
added a commit
to tsachiherman/go-algorand
that referenced
this pull request
Jul 7, 2021
Rebase transaction sync with master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rebase transaction sync with master
Test Plan
Use existing tests