-
Notifications
You must be signed in to change notification settings - Fork 524
Closed
Labels
Description
Subject of the issue
There is a dynamic "label" feature in Gauge and StringGauge. The label is a string argument when collecting metrics used as a key into the gauge dataset. If we ever use the feature for something unbound like round, address or session ID. At that point memory would grow unbounded until a crash.
A couple of possible solutions (we would need to do this for both gauges):
- Remove the
labelsfeature (it seems to only be used bysegment.go:EnterSegmentand that function is not called anywhere). - Return from this function immediately when
len(valueIndices) <= 1 - Set
maxMetricRetensionDurationto something very large inconfig.json
Earlier discussion here: #2508 (comment)
Acceptance criteria
Remove labels that can be associated with metrics.
Why: using the labels may lead to memory issues that lead to the node crashing.
Priority
Low / Tech debt