-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Add docker to the release pipeline #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me + Docker image builds successfully on my local machine.
I can't seem to run it locally due to exec: "./conduit": permission denied: unknown
errors.
I was playing around with possibly giving more informative suggestions by looking at the command's exec path, the current working directory, and computing a rel-path. But then I convinced myself that it wasn't worth it. |
This Dockerfile needs goreleaser to build it, it does something special which puts the precompiled binaries at the root of the filesystem. I'm not exactly sure what the unknown permission denied error is, but I'm sure it's related. The benefit is you know the artifacts in the tar files are identical to the ones in the docker image. The downside is you can't build it normally. Can you think of a way to help people avoid trying to build it manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goreleaser release --skip-publish --snapshot --clean
(instead of docker build
) did fix my issue, LGTM
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 67.66% 66.23% -1.43%
==========================================
Files 32 33 +1
Lines 1976 1869 -107
==========================================
- Hits 1337 1238 -99
+ Misses 570 566 -4
+ Partials 69 65 -4 see 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I echo @algochoi 's observation that --clean
is prefered over the now deprecated --rm-dist
Summary
Add a docker multi-arch build + deployment configuration.
For now the docker hub deployment is disabled.Hyperflow has added credentials to the repo so that the container can be deployed.Goreleaser provides binaries from the build step to the Dockerfile to ensure containers have the same files as the archives.
Test Plan
Tested with
goreleaser release --skip-publish --snapshot --clean
The files are here:
The architecture appears as expected: