Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error message and remove catchpoint label from algod importer sample. #109

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jun 22, 2023

Summary

Addresses usability feedback:

  1. Info logs for fast catchup detection sounded like an error. Attempt to clarify that this is an expected state for a node that needs to be initialized.
  2. Remove "catchpoint" setting from config sample. With the automated fast catchup, this setting no longer very useful. It doesn't need to be removed, but it doesn't need to be prominently displayed.

Test Plan

Existing unit tests.

@winder winder requested review from algobarb and algoanne June 22, 2023 19:35
@winder winder requested a review from a team as a code owner June 22, 2023 20:47
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #109 (6b77ba0) into master (442791a) will increase coverage by 2.64%.
The diff coverage is 77.29%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   67.66%   70.30%   +2.64%     
==========================================
  Files          32       37       +5     
  Lines        1976     2512     +536     
==========================================
+ Hits         1337     1766     +429     
- Misses        570      651      +81     
- Partials       69       95      +26     
Impacted Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/metrics/metrics.go 100.00% <ø> (ø)
conduit/pipeline/metadata.go 69.11% <ø> (ø)
...duit/plugins/exporters/filewriter/file_exporter.go 81.63% <ø> (-1.06%) ⬇️
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...ins/processors/filterprocessor/filter_processor.go 83.82% <ø> (+3.54%) ⬆️
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
conduit/plugins/processors/noop/noop_processor.go 64.70% <ø> (+6.81%) ⬆️
pkg/cli/internal/list/list.go 20.75% <ø> (ø)
...lugins/exporters/postgresql/postgresql_exporter.go 65.68% <51.21%> (-12.52%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder merged commit c6fa366 into algorand:master Jun 23, 2023
@winder winder deleted the will/workshop-feedback branch June 23, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants