Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics to include inner transactions. #105

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jun 15, 2023

Summary

Update metrics to consider inner transactions.

Test Plan

New unit test.

@winder winder requested a review from a team June 15, 2023 17:11
@winder winder self-assigned this Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #105 (94413ce) into master (442791a) will increase coverage by 2.27%.
The diff coverage is 76.68%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   67.66%   69.93%   +2.27%     
==========================================
  Files          32       36       +4     
  Lines        1976     2428     +452     
==========================================
+ Hits         1337     1698     +361     
- Misses        570      641      +71     
- Partials       69       89      +20     
Impacted Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/metrics/metrics.go 100.00% <ø> (ø)
...duit/plugins/exporters/example/example_exporter.go 87.50% <ø> (-1.39%) ⬇️
...duit/plugins/exporters/filewriter/file_exporter.go 81.63% <ø> (-1.06%) ⬇️
conduit/plugins/exporters/noop/noop_exporter.go 73.68% <ø> (-3.59%) ⬇️
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...ins/processors/filterprocessor/filter_processor.go 83.82% <ø> (+3.54%) ⬆️
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
conduit/plugins/processors/noop/noop_processor.go 64.70% <ø> (+6.81%) ⬆️
pkg/cli/internal/list/list.go 20.75% <ø> (ø)
... and 11 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder requested a review from shiqizng June 16, 2023 18:46
Copy link
Contributor

@shiqizng shiqizng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just a commented line that looks out of place.

innerTxn += numInnerTxn(txn.SignedTxnWithAD)
}
if innerTxn != 0 {
txnCountByType["inner"] = innerTxn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it may be ok to record 0 inner txn count in this metric.

conduit/pipeline/pipeline_test.go Outdated Show resolved Hide resolved
@winder winder merged commit 8328991 into algorand:master Jun 16, 2023
@winder winder deleted the will/txn-count-inner branch June 16, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants