-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics to include inner transactions. #105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 67.66% 69.93% +2.27%
==========================================
Files 32 36 +4
Lines 1976 2428 +452
==========================================
+ Hits 1337 1698 +361
- Misses 570 641 +71
- Partials 69 89 +20
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just a commented line that looks out of place.
innerTxn += numInnerTxn(txn.SignedTxnWithAD) | ||
} | ||
if innerTxn != 0 { | ||
txnCountByType["inner"] = innerTxn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it may be ok to record 0 inner txn count in this metric.
Summary
Update metrics to consider inner transactions.
Test Plan
New unit test.