atc transactions sent #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Bug Submission Pull Request
What was the bug?
atc.addTransaction({txn: ptxn1, signer: sender})
atc.addTransaction({txn: ptxn2, signer: sender})
property signer can not be assigned by sender, type error
The warning given by VS Code is:
Type 'Account' is not assignable to type 'TransactionSigner'.
Type 'Account' provides no match for the signature '(txnGroup: Transaction[], indexesToSign: number[]): Promise<Uint8Array[]>'.ts(2322)
signer.d.ts(38, 5): The expected type comes from property 'signer' which is declared here on type 'TransactionWithSigner'
(property) TransactionWithSigner.signer: algosdk.TransactionSigner
A transaction signer that can authorize txn
How did you fix the bug?
Opening signer.d.ts, I found the following function
export declare function makeBasicAccountTransactionSigner(account: Account): TransactionSigner;
Using that function, I created a signer, and used that signer in atc.addTransaction:
const signer = algosdk.makeBasicAccountTransactionSigner(sender)
atc.addTransaction({txn: ptxn1, signer: signer})
atc.addTransaction({txn: ptxn2, signer: signer})
Console Screenshot:
