Fixed the bug! #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Congrats on solving the 4th Algorand Coding Challenge! I have labeled your PR approved, so you can now claim your certificate. You can claim your certificate of completion NFT here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Bug Submission Pull Request
What was the bug?
The error when running the file before fixing the bug showed: "TypeError: signer is not a function" This means inside the atc.addTransaction part it was not recognising the signer of the transactions.
How did you fix the bug?
I remember going through a very similar code during one of the teaching sessions from the dev-rel team, and I noticed I had to instantiate a signer. I fixed the bug by creating a signer with the algosdk makeBasicAccountTransactionSigner Function. I then passed the sender account through the parameters and I called this with the variable name senderSigner. I then replaced the sender for the senderSigner within the atc transactions.
Basically like so:
const senderSigner = algosdk.makeBasicAccountTransactionSigner(sender)
...
atc.addTransaction({txn: ptxn1, signer: senderSigner})
Console Screenshot: