bugfix: Uncomment return statement #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful explanation 🎉 Congrats on solving the 2nd Algorand Coding Challenge! I have labeled your PR approved so you can now claim your certificate. You can claim your certificate of completion NFT here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algorand Coding Challenge Submission
What was the bug?
Return statement of
AlgorandPuzzle2.solveThePuzzle()was commented out, and therefore, by default, the function returnsundefined. This is a violation of the typescript definition of the function which says it should return a value of typestring.How did you fix the bug?
Uncommented the return statement.
I also forgot to pull in dependencies before running
npm run testthe first time, so I received the following error:sh: 1: tealscript: not found. This was resolved by runningalgokit bootstrap npm, which under the hood, runsnpm install, and since tealscript is listed as a dependency inpackage.json, this dependency issue was satisfied.Console Screenshot: