Fix compatibility with Sphinx <7 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
changed the title
Console properties were moved under `sphinx.utils.display` in sphinx-doc/sphinx@8c5e701 which was released in Sphinx 7 This means `sphinx_docsearch` doesn't work with Sphinx <7 . This will make it comaptible with it.
Collaborator
|
@kaxil Thanks for fixing this! |
Contributor
Author
|
Could you cut a new release @kai687 ? |
Collaborator
|
I have some technical difficulties uploading to PyPI at the moment, otherwise I would have done it already. It'll take a week or two. |
Contributor
Author
aah no worries, thank you :) |
Contributor
Author
|
I want to use it for Apache Airflow and we have Sphinx pinned at <7 for now, let's see if I am able to fix with my attempt to upgrade it here: apache/airflow#39449 |
Collaborator
|
@kaxil finally, I could release version 0.0.5 which contains your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console properties were moved under
sphinx.utils.displayin sphinx-doc/sphinx@8c5e701 which was released in Sphinx 7This means
sphinx_docsearchdoesn't work with Sphinx <7 . This will make it comaptible with it since sphinx-docsearch technically supports those versions:sphinx-docsearch/pyproject.toml
Lines 22 to 25 in 0c5ad99