feat(data): add concatenated name #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
commented
Mar 28, 2017
formatPkg.js
Outdated
| } | ||
|
|
||
| const dependencies = cleaned.dependencies || {}; | ||
| const charsToSplit = /[-/@_.]+/; |
There was a problem hiding this comment.
added . to split on here too
iam4x
reviewed
Mar 28, 2017
formatPkg.js
Outdated
| name: cleaned.name, | ||
| numberOfWordsInName: cleaned.name.split(/[-/@_]+/).length, | ||
| concatenatedName, | ||
| numberOfWordsInName: cleaned.name.split(charsToSplit).length, |
There was a problem hiding this comment.
'r-a-b-c'.split(/[-/@_.]+/g)
-> (4) ["r", "a", "b", "c"]So you can directly do, instead of calling a new RegExp() constructor 👍
const charsToSplit = /[-/@_.]+/g;
const concatenatedName = cleaned.name.replace(charsToSplit, '');
[..]
numberOfWordsInName: cleaned.name.split(charsToSplit).length
Haroenv
force-pushed
the
feat/add-concatenated-name
branch
from
e40b71c to
72ab12e
Compare
|
I removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33