Skip to content

fix(compareBar): disable Compare while the chat is busy - #7308

Draft
Haroenv wants to merge 1 commit into
fix/compare-chat-lookupfrom
fix/compare-bar-chat-busy
Draft

Haroenv wants to merge 1 commit into
fix/compare-chat-lookupfrom
fix/compare-bar-chat-busy

Conversation

@Haroenv

@Haroenv Haroenv commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #7305.

The compareBar Compare button stayed enabled while the chat was busy (submitted/streaming). Clicking it opened the chat but did not send the comparison, so the click looked like it did nothing. Every other chat entry point already disables its button while the chat is busy.

Result

  • connectCompare exposes isChatBusy in its render state, computed like connectPromptSuggestions (busy when the chat has no sendMessage or is submitting/streaming), using the shared getChatRenderState lookup. It is false when no chat is found. canCompare still only means the selection is big enough.
  • The shared CompareBar UI component takes an optional isChatBusy prop; the Compare button is disabled={!canCompare || isChatBusy}.
  • The JS compareBar widget and the React <CompareBar> pass isChatBusy through. The button re-enables when the chat status returns to ready.
  • Tests: connector tests for isChatBusy following the chat status, and a CompareBar UI component test for the disabled/enabled button.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity

Metric Results
Complexity 4

View in Codacy

TIP This summary will be updated as you push new changes.

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026

Copy link
Copy Markdown
More templates

algoliasearch-helper

npm i https://pkg.pr.new/algolia/instantsearch/algoliasearch-helper@7308

instantsearch-ui-components

npm i https://pkg.pr.new/algolia/instantsearch/instantsearch-ui-components@7308

instantsearch.css

npm i https://pkg.pr.new/algolia/instantsearch/instantsearch.css@7308

instantsearch.js

npm i https://pkg.pr.new/algolia/instantsearch/instantsearch.js@7308

react-instantsearch

npm i https://pkg.pr.new/algolia/instantsearch/react-instantsearch@7308

react-instantsearch-core

npm i https://pkg.pr.new/algolia/instantsearch/react-instantsearch-core@7308

react-instantsearch-nextjs

npm i https://pkg.pr.new/algolia/instantsearch/react-instantsearch-nextjs@7308

react-instantsearch-router-nextjs

npm i https://pkg.pr.new/algolia/instantsearch/react-instantsearch-router-nextjs@7308

vue-instantsearch

npm i https://pkg.pr.new/algolia/instantsearch/vue-instantsearch@7308

commit: 845eacd

@github-actions

Copy link
Copy Markdown

Size Change: +212 B (+0.02%)

Total Size: 1.04 MB

📦 View Changed
Filename Size Change
packages/instantsearch.js/dist/instantsearch.development.js 334 kB +120 B (+0.04%)
packages/instantsearch.js/dist/instantsearch.production.min.js 152 kB +34 B (+0.02%)
packages/react-instantsearch-core/dist/umd/ReactInstantSearchCore.min.js 73.9 kB +22 B (+0.03%)
packages/react-instantsearch/dist/umd/ReactInstantSearch.min.js 126 kB +36 B (+0.03%)
ℹ️ View Unchanged
Filename Size Change
packages/algoliasearch-helper/dist/algoliasearch.helper.js 44.5 kB 0 B
packages/algoliasearch-helper/dist/algoliasearch.helper.min.js 14.1 kB -1 B (-0.01%)
packages/instantsearch.css/components/ai-mode-button.css 1.76 kB 0 B
packages/instantsearch.css/components/autocomplete-min.css 4.33 kB 0 B
packages/instantsearch.css/components/autocomplete.css 4.68 kB 0 B
packages/instantsearch.css/components/button.css 1.98 kB 0 B
packages/instantsearch.css/components/chat-min.css 7.4 kB 0 B
packages/instantsearch.css/components/chat.css 7.91 kB 0 B
packages/instantsearch.css/components/filter-suggestions.css 1.89 kB 0 B
packages/instantsearch.css/themes/algolia-min.css 11.9 kB 0 B
packages/instantsearch.css/themes/algolia.css 12.6 kB 0 B
packages/instantsearch.css/themes/nova-min.css 12 kB 0 B
packages/instantsearch.css/themes/nova.css 12.8 kB 0 B
packages/instantsearch.css/themes/reset-min.css 1.3 kB 0 B
packages/instantsearch.css/themes/reset.css 1.38 kB 0 B
packages/instantsearch.css/themes/satellite-min.css 12.8 kB 0 B
packages/instantsearch.css/themes/satellite.css 13.7 kB 0 B
packages/vue-instantsearch/vue2/cjs/index.js 19.9 kB 0 B
packages/vue-instantsearch/vue2/umd/index.js 74.3 kB -4 B (-0.01%)
packages/vue-instantsearch/vue3/cjs/index.js 20.6 kB 0 B
packages/vue-instantsearch/vue3/umd/index.js 74.7 kB -6 B (-0.01%)

compressed-size-action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant