Skip to content

fix(specs): ingestion small fix + added source input descriptions #5515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

fix(specs): ingestion small fix + added source input descriptions #5515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b725b2
fix(ingestion): remove 'platform' from updatable auth attributes
sbellone Oct 20, 2025
a375eab
chore(ingestion): add descriptions to source input objects
sbellone Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions specs/ingestion/common/schemas/authentication.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ AuthenticationUpdate:
$ref: '#/AuthenticationType'
name:
$ref: './common.yml#/name'
platform:
$ref: '#/Platform'
input:
$ref: '#/AuthInputPartial'

Expand Down
14 changes: 12 additions & 2 deletions specs/ingestion/common/schemas/source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ SourceType:

SourceCommercetools:
type: object
description: Specific configuration attributes of a `commercetools` source.
additionalProperties: false
properties:
storeKeys:
Expand All @@ -125,7 +126,7 @@ SourceCommercetools:
items:
type: string
pattern: '^[a-z]{2}(-[A-Z]{2})?$'
description: Locale specfied as combination of a two-letter language code and an optional two-letter country code.
description: Locale specified as combination of a two-letter language code and an optional two-letter country code.
example: 'fr-FR'
url:
type: string
Expand Down Expand Up @@ -180,6 +181,7 @@ CommercetoolsCustomFields:

SourceBigCommerce:
type: object
description: Specific configuration attributes of a `bigcommerce` source.
additionalProperties: false
properties:
storeHash:
Expand Down Expand Up @@ -247,6 +249,7 @@ UniqueIDColumn:

SourceJSON:
type: object
description: Specific configuration attributes of a `json` source.
additionalProperties: false
properties:
url:
Expand All @@ -265,6 +268,7 @@ MappingTypeCSV:

SourceCSV:
type: object
description: Specific configuration attributes of a `csv` source.
additionalProperties: false
properties:
url:
Expand Down Expand Up @@ -292,6 +296,7 @@ SourceCSV:

SourceGA4BigQueryExport:
type: object
description: Specific configuration attributes of a `ga4BigqueryExport` source.
additionalProperties: false
properties:
projectID:
Expand All @@ -315,6 +320,7 @@ SourceGA4BigQueryExport:

SourceBigQuery:
type: object
description: Specific configuration attributes of a `bigquery` source.
additionalProperties: false
properties:
projectID:
Expand Down Expand Up @@ -348,6 +354,7 @@ BigQueryDataType:

SourceDocker:
type: object
description: Specific configuration attributes of a `docker` source.
additionalProperties: false
properties:
image:
Expand All @@ -366,6 +373,7 @@ SourceDocker:

SourceUpdateDocker:
type: object
description: Specific configuration attributes of a `docker` source.
additionalProperties: false
properties:
configuration:
Expand All @@ -389,6 +397,7 @@ SourceInput:

SourceUpdateCommercetools:
type: object
description: Specific configuration attributes of a `commercetools` source.
additionalProperties: false
properties:
storeKeys:
Expand All @@ -402,7 +411,7 @@ SourceUpdateCommercetools:
items:
type: string
pattern: '^[a-z]{2}(-[A-Z]{2})?$'
description: Locale specfied as combination of a two-letter language code and an optional two-letter country code.
description: Locale specified as combination of a two-letter language code and an optional two-letter country code.
example: 'fr-FR'
url:
type: string
Expand All @@ -429,6 +438,7 @@ SourceUpdateInput:

SourceUpdateShopify:
type: object
description: Specific configuration attributes of a `shopify` source.
additionalProperties: false
properties:
featureFlags:
Expand Down