fix(specs): allow one sided rule validity #5060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
indeed, and scala, but the spec was not correct so it's still a fix right ? |
yup, just makes me think that we should have a way to properly reflect those in changelogs |
algolia-bot
added a commit
that referenced
this pull request
Jul 4, 2025
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Jul 4, 2025
algolia/api-clients-automation#5060 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: CR-8889
Time ranges for rule can be one sided, we can't express that in openapi without using a one of, so we just make them both optional.