Skip to content

feat(specs): add new ingestion property for push #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3903

Changes included:

this new property is only available on the push per index name endpoint

@shortcuts shortcuts self-assigned this Jun 16, 2025
@shortcuts shortcuts requested a review from a team as a code owner June 16, 2025 11:14
@shortcuts shortcuts requested review from morganleroi and Fluf22 June 16, 2025 11:14
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 16, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by d4960b99f61fcf3231730c23fd6abf1facf869c9
🍃 Generated commit 7bd9c638ed77eb8297ec5a275a0ce640db70909a
🌲 Generated branch generated/feat/ingestion-referenceIndexName
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1746
javascript 1669
php 1509
csharp 1280
java 1122
python 1082
ruby 820
swift 801
scala 23

@shortcuts shortcuts enabled auto-merge (squash) June 16, 2025 11:14
millotp
millotp previously approved these changes Jun 16, 2025
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -20,6 +20,12 @@ post:
parameters:
- $ref: '../../common/parameters.yml#/IndexName'
- $ref: '../common/parameters.yml#/watch'
- name: referenceIndexName
in: query
description: This is required to be provided when targeting an index that does not have a push connector setup (e.g. a tmp index), but you wish to attach another index's transformation to it (e.g. the source index name).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: This is required to be provided when targeting an index that does not have a push connector setup (e.g. a tmp index), but you wish to attach another index's transformation to it (e.g. the source index name).
description: This is required when targeting an index that does not have a push connector setup (e.g. a tmp index), but you wish to attach another index's transformation to it (e.g. the source index name).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with the java fix bb7aeb2

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@shortcuts shortcuts merged commit 973cc0c into main Jun 16, 2025
28 checks passed
@shortcuts shortcuts deleted the feat/ingestion-referenceIndexName branch June 16, 2025 14:13
algolia-bot added a commit that referenced this pull request Jun 16, 2025
…[skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jun 16, 2025
algolia/api-clients-automation#5007

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants