Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): adjust style for banner descriptions #4362

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix(specs): adjust style for banner descriptions #4362

merged 2 commits into from
Jan 16, 2025

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jan 16, 2025

🧭 What and Why

Fix capitalization of description fields for parameters related to banners.

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 16, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 8fc7e5a7e759182b33fa86988ddb7c9f1113f5a6
🍃 Generated commit 152f9477fb70a7d3b400ea32ce2db5b1f61ec718
🌲 Generated branch generated/fix/banner
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1658
go 1636
php 1443
csharp 1268
java 1137
python 1027
ruby 828
swift 752

@kai687 kai687 marked this pull request as ready for review January 16, 2025 13:27
@kai687 kai687 requested a review from a team as a code owner January 16, 2025 13:27
@kai687 kai687 requested review from millotp and shortcuts January 16, 2025 13:27
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ! don't worry about the breaking change comment, we need to release to make it go away

@shortcuts shortcuts merged commit 952639f into main Jan 16, 2025
28 checks passed
@shortcuts shortcuts deleted the fix/banner branch January 16, 2025 22:02
algolia-bot added a commit that referenced this pull request Jan 16, 2025
…[skip ci]

Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 16, 2025
algolia/api-clients-automation#4362

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants