Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): optionalFilters additional explanation [skip-bc] #4353

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jan 13, 2025

🧭 What and Why

Port an amendment to the optionalFilters API parameter DOC PR 9656, explaining that optionalFilters are usually applied before custom ranking.

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CR-7529

Changes included:

  • Mention that in the default ranking, optionalFilters are applied before custom ranking

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 13, 2025

✔️ Code generated!

Name Link
🪓 Triggered by a6d8d6437b00dd6f1c0780fadeb6529ad30f95a8
🍃 Generated commit 8181aa60b6215a947bd232bc48a4a41a8d36f6ae
🌲 Generated branch generated/fix/specs/optionalFilters
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1598
javascript 1550
php 1502
csharp 1407
java 1134
python 1085
ruby 802
swift 761

@kai687 kai687 changed the title fix(specs): optionalFilters ammendment fix(specs): optionalFilters additional explanation Jan 13, 2025
@kai687 kai687 marked this pull request as ready for review January 13, 2025 12:18
@kai687 kai687 requested a review from a team as a code owner January 13, 2025 12:18
@kai687 kai687 requested review from millotp and shortcuts January 13, 2025 12:18
@shortcuts shortcuts changed the title fix(specs): optionalFilters additional explanation fix(specs): optionalFilters additional explanation [skip-bc] Jan 13, 2025
@shortcuts shortcuts enabled auto-merge (squash) January 13, 2025 12:28
@shortcuts shortcuts merged commit 58cc544 into main Jan 13, 2025
28 checks passed
@shortcuts shortcuts deleted the fix/specs/optionalFilters branch January 13, 2025 12:33
algolia-bot added a commit that referenced this pull request Jan 13, 2025
…(generated) [skip ci]

Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 13, 2025
algolia/api-clients-automation#4353

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants