Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): add ignoreConjugations to AlternativesAsExact [skip-bc] #4230

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix(specs): add ignoreConjugations to AlternativesAsExact [skip-bc] #4230

merged 3 commits into from
Dec 11, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

reported by @kombucha, this property is missing on the allowed enum values

@shortcuts shortcuts self-assigned this Dec 11, 2024
@shortcuts shortcuts requested a review from a team as a code owner December 11, 2024 14:06
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 11, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by daddb78bf36497406dadee9636fe0ff8062c31e4
🍃 Generated commit 8ae2878973a2ee91e3204f8ff1163fbfcb46c263
🌲 Generated branch generated/fix/AlternativesAsExact
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1675
javascript 1640
php 1484
csharp 1352
java 1122
python 1071
ruby 884
swift 750

@shortcuts shortcuts changed the title fix(specs): add ignoreConjugations to AlternativesAsExact fix(specs): add ignoreConjugations to AlternativesAsExact [skip-bc] Dec 11, 2024
@kombucha
Copy link
Contributor

While this will help in the short term, ideally we shouldn't see the client crashing anytime the engine adds new valid values / extra properties IMO.
Something like #4143, but also applied to enum values and such would be desirable 👀

@shortcuts
Copy link
Member Author

While this will help in the short term, ideally we shouldn't see the client crashing anytime the engine adds new valid values / extra properties IMO. Something like #4143, but also applied to enum values and such would be desirable 👀

yup @millotp is taking a look at it!

@shortcuts shortcuts enabled auto-merge (squash) December 11, 2024 21:28
@shortcuts shortcuts merged commit baf7d6f into main Dec 11, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/AlternativesAsExact branch December 11, 2024 21:41
algolia-bot added a commit that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
34cc8bf 
…c] (#4230) (generated) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
d737e7b 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
44c3eaf 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
51dbb1c 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
1e79fbe 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
32f8eb7 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
67cf8f3 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
a8f3eb8 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
1c25820 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
0e34a8e 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
a7ab37d 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Dec 11, 2024
@algolia-bot @shortcuts
fix(specs): add ignoreConjugations to AlternativesAsExact [skip-b…
df79f04 
…c] (generated)

algolia/api-clients-automation#4230

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shortcuts @algolia-bot @kombucha @millotp