Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): alternativesAsExact is plurals and synonyms #3974

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

gazconroy
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DOC-1534

Changes included:

alternativesAsExact is about changing the default singular/plural and synonym behaviour. This helps clarify that and provides more context.

@gazconroy gazconroy requested a review from a team as a code owner October 15, 2024 13:35
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 15, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 34ff606bd69425ba0d000521ac70c609f2af25a4
🍃 Generated commit 764902fc4a5a0146e9a3ede1bf776fbf63b44050
🌲 Generated branch generated/fix/alternativesAsExact
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1652
go 1568
php 1477
csharp 1399
java 1083
python 1024
ruby 900
swift 748

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Fluf22 Fluf22 enabled auto-merge (squash) October 15, 2024 13:41
@millotp millotp disabled auto-merge October 15, 2024 13:41
@millotp millotp enabled auto-merge (squash) October 15, 2024 14:00
@millotp millotp merged commit 8b879de into main Oct 15, 2024
28 checks passed
@millotp millotp deleted the fix/alternativesAsExact branch October 15, 2024 14:19
algolia-bot added a commit that referenced this pull request Oct 15, 2024
…rated) [skip ci]

Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3974

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants