Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): recommend _score is optional #3967

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix(specs): recommend _score is optional #3967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87fc13c
fix(specs): recommend `_score` is optional
shortcuts Oct 14, 2024
545a6a0
chore: @millotp and @fluf22 = saboteurs
shortcuts Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
runs-on: ubuntu-22.04
timeout-minutes: 10
env:
CACHE_VERSION: 1 # bump this to run all clients on the CI.
CACHE_VERSION: 1.01 # bump this to run all clients on the CI.
steps:
- name: debugging - dump GitHub context
env:
Expand Down
2 changes: 0 additions & 2 deletions specs/recommend/common/schemas/RecommendationsResponse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ recommendHit:
additionalProperties: true
required:
- objectID
- _score
properties:
objectID:
$ref: '../../../common/parameters.yml#/objectID'
Expand All @@ -48,7 +47,6 @@ trendingFacetHit:
type: object
description: Trending facet hit.
required:
- _score
- facetName
- facetValue
properties:
Expand Down
Loading