Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): add react-native field in package.json #3767

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Sep 17, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2939

closes algolia/algoliasearch-client-javascript#1554

Changes included:

seems like a regression when adding the tsup bundler, I assumed the browser was covered with the exports field but metro only provides an experimental support for it, we can leverage browser in the meantime

@shortcuts shortcuts self-assigned this Sep 17, 2024
@shortcuts shortcuts requested a review from a team as a code owner September 17, 2024 21:16
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 17, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 37bd08a4e7b14b8652b2766ad581c2480210676d
🍃 Generated commit 626b470129334232d0da25a1230d0e46131af536
🌲 Generated branch generated/feat/javascript-browser-field
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1730

millotp
millotp previously approved these changes Sep 18, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that break something with cloudflare or react native ?

@shortcuts
Copy link
Member Author

Will that break something with cloudflare or react native ?

For cloudflare it should ignore it, for react native it should fix it

@shortcuts shortcuts enabled auto-merge (squash) September 18, 2024 09:01
@shortcuts shortcuts changed the title feat(javascript): add browser field in package.json feat(javascript): add react-native field in package.json Sep 18, 2024
@shortcuts shortcuts enabled auto-merge (squash) September 18, 2024 09:49
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@shortcuts shortcuts merged commit d67c0e0 into main Sep 18, 2024
13 checks passed
@shortcuts shortcuts deleted the feat/javascript-browser-field branch September 18, 2024 09:49
algolia-bot added a commit that referenced this pull request Sep 18, 2024
…erated) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 18, 2024
algolia/api-clients-automation#3767

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants