Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ruby): correct oneOf deserialization #2559

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix(ruby): correct oneOf deserialization #2559

merged 2 commits into from
Jan 17, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 17, 2024

🧭 What and Why

The ruby client was broken because of the change of namespaces.

@millotp millotp self-assigned this Jan 17, 2024
@millotp millotp requested a review from a team as a code owner January 17, 2024 11:44
@millotp millotp requested review from damcou and shortcuts January 17, 2024 11:44
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit cb6a8dc
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65a7be596073a60008576ca3
😎 Deploy Preview https://deploy-preview-2559--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 17, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@millotp millotp merged commit 6c099d4 into main Jan 17, 2024
16 checks passed
@millotp millotp deleted the fix/ruby-one-of branch January 17, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millotp @algolia-bot @shortcuts