Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruby): support ruby alpha format #2447

Merged
merged 4 commits into from
Dec 28, 2023
Merged

fix(ruby): support ruby alpha format #2447

merged 4 commits into from
Dec 28, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 28, 2023

🧭 What and Why

Syntax like 3.0.0.alpha.0 was not supported by getNextVersion.

@millotp millotp self-assigned this Dec 28, 2023
@millotp millotp requested a review from a team as a code owner December 28, 2023 14:14
@millotp millotp requested review from damcou and Fluf22 December 28, 2023 14:14
Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 9fccdd4
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/658d89ba92968d0009c11bf2
😎 Deploy Preview https://deploy-preview-2447--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 28, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 previously approved these changes Dec 28, 2023
Comment on lines 179 to 181
// python alpha releases have a pattern like X.Y.ZaN
// where a means alpha and N can be any digit representing the alpha version
// see https://peps.python.org/pep-0440/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this comment not related anymore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be expanded to ruby indeed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still relevant for python, but also support ruby now, I can add a small com

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe remove it? I feel like the regex is self explanatory 😁
It's true we could document every language specificity to know why the regex get more complex each time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully we won't stumble across new version format ! this should support everything

Copy link
Collaborator Author

@millotp millotp Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quoi que, ruby has 2.0.0.pre.alpha.2

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheeesh

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@millotp millotp enabled auto-merge (squash) December 28, 2023 14:44
@millotp millotp merged commit 9f4f175 into main Dec 28, 2023
21 of 37 checks passed
@millotp millotp deleted the fix/release-ruby branch December 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants