feat(ruby): retry strategy #2383
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
I see some files out of the http folder, wdyt of having all of them there for easier scoping of what's not generated?
There was a problem hiding this comment.
I did it to match the old client, I think what's inside http is what can be exchanged for a echo requester for example
There was a problem hiding this comment.
not a blocker anyway but I feel like it's better if we scope everything related to the transporter in the same folder
| # TODO: what is this merge for ? | ||
| # request_options.params.merge!(request_options.data) if method == :GET |
There was a problem hiding this comment.
we proxy the POST payload in QP if it's a get request IIRC
There was a problem hiding this comment.
or the other way around but I think there's something like that
clients/algoliasearch-client-ruby/lib/algolia/transport/retry_strategy.rb
Show resolved
Hide resolved
🧭 What and Why
🎟 JIRA Ticket: DI-1718
Bring in the retry strategy from the existing client, and try to make it work with the generated one.
The error handling is not perfect and will be improved in future PR.