Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ruby): make the playground work #2379

Merged
merged 3 commits into from
Dec 18, 2023
Merged

fix(ruby): make the playground work #2379

merged 3 commits into from
Dec 18, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 15, 2023

🧭 What and Why

Add app_id, api_key and region to the client, make the hosts work (no retry strategy for now), and fix the playground.

@millotp millotp self-assigned this Dec 15, 2023
@millotp millotp requested a review from a team as a code owner December 15, 2023 17:47
@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit fb755b5
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/657d7a6a80450800085b02bd
😎 Deploy Preview https://deploy-preview-2379--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 15, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, and 90k deletion is HUGE

@millotp millotp merged commit 614d56a into main Dec 18, 2023
24 checks passed
@millotp millotp deleted the fix/ruby-playground branch December 18, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millotp @algolia-bot @shortcuts