Skip to content

fix(ruby): add libraries in the Dockerfile #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(ruby): add libraries in the Dockerfile #2333

merged 1 commit into from
Dec 4, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 4, 2023

🧭 What and Why

The ruby setup was broken, we need more dependencies, use the correct folder, and export the correct path.

@millotp millotp self-assigned this Dec 4, 2023
@millotp millotp requested a review from a team as a code owner December 4, 2023 11:46
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit f15f0d5
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/656dbc0078a436000890affb
😎 Deploy Preview https://deploy-preview-2333--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 4, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noiiice

RUN wget -O ruby.tar.gz https://github.com/postmodern/ruby-install/releases/download/v0.9.2/ruby-install-0.9.2.tar.gz \
&& tar -xzvf ruby.tar.gz && cd ruby && make install && ruby-install ruby ${RUBY_VERSION} && gem install bundler
RUN echo "export PATH=$PATH:/opt/rubies/ruby-${RUBY_VERSION}/bin" >> ~/.profile && source ~/.profile
RUN curl -L -o ruby.tar.gz https://github.com/postmodern/ruby-install/releases/download/v0.9.2/ruby-install-0.9.2.tar.gz \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the redirect?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the -L yes, it redirects to some obsure raw.githubusercontent address

@millotp millotp merged commit a8f2565 into main Dec 4, 2023
@millotp millotp deleted the fix/docker-ruby branch December 4, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants