Skip to content

fix(insights): properly divide viewed objects events #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

aymeric-giraudet
Copy link
Member

@aymeric-giraudet aymeric-giraudet commented Jul 25, 2025

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue CR-9049
Need Doc update no

Describe your change

Seems like a problem with copy/pasting, variable shadowing and lack of linting tools.
Still named the variable the same as for other methods even if it shadows the upper scope objectIDs array.

What problem is this fixing?

Events were split but sent the whole objectIDs array, causing an error

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, looks the same as the other methdos

@aymeric-giraudet aymeric-giraudet merged commit f68c33d into main Jul 28, 2025
6 checks passed
@aymeric-giraudet aymeric-giraudet deleted the fix/viewed-objects-chunk branch July 28, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants