fix: update dependencies #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. make sure `preact-compat` is at a version which supports IE11 fixes https://github.com/algolia/algoliasearch-magento-2/issues/535 See for more information also preactjs/preact-compat#423, which is the original fix of the bug 2. make sure there's no duplicate dependency versions by using Yarn resolutions NOTE: you can only use Yarn now to build, not npm.
Haroenv
commented
Aug 2, 2018
| "hogan.js": "^3.0.2", | ||
| "instantsearch.js": "^2.4.0", | ||
| "instantsearch.js": "^2.9.0", | ||
| "preact-compat": "^3.18.2", |
There was a problem hiding this comment.
this is the important one, it used to be 3.17.x, which has the bug described
JanPetr
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preact-compatis at a version which supports IE11fixes https://github.com/algolia/algoliasearch-magento-2/issues/535
See for more information also preactjs/preact-compat#423, which is the original fix of the bug
NOTE: you can only use Yarn now to build, not npm.