fix(getSettings): allow empty call #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerska
approved these changes
Feb 8, 2018
vvo
reviewed
Feb 8, 2018
| .then(function() {return index.getSettings({advanced: 1});}) | ||
| .then(get('attributesForFaceting')) | ||
| .then(_.partialRight(t.deepEqual, ['searchable(category)'], 'Settings were get (advanced)')) | ||
| .then(index.getSettings) |
There was a problem hiding this comment.
Here getSettings is called with one argument (result from previous Promise, even undefined wdyt?
There was a problem hiding this comment.
good call, amending the test to be really with no arguments
vvo
reviewed
Feb 8, 2018
| */ | ||
| Index.prototype.getSettings = function(opts, callback) { | ||
| if (arguments.length === 1 || typeof opts === 'function') { |
There was a problem hiding this comment.
You could also have added opts = opts || {} after the original if no? Would that have worked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in f91cdde accidentally a first argument was necessary.
Result
no more error with empty arguments