Skip to content

fix(types): Updating searchoptions with explain attribute#1415

Merged
Haroenv merged 2 commits intomasterfrom
feat/add-explain-attr
Jul 18, 2022
Merged

fix(types): Updating searchoptions with explain attribute#1415
Haroenv merged 2 commits intomasterfrom
feat/add-explain-attr

Conversation

@cdhawke
Copy link
Contributor

@cdhawke cdhawke commented Jul 18, 2022

Motivation

  • Update the SearchOptions to include explain as a typed parameter for better use within the Algolia dashboard

How

  • Adds the explain attribute as a string[] to the V4 SearchOptions.

Testing

  • Test cases shouldn't change. The attribute is already included in a search test here

@cdhawke cdhawke added the TypeScript Problems related to TypeScript definitions label Jul 18, 2022
@cdhawke cdhawke requested a review from Haroenv July 18, 2022 13:47
@cdhawke cdhawke self-assigned this Jul 18, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0a9119:

Sandbox Source
javascript-client-app Configuration

@cdhawke cdhawke requested a review from Haroenv July 18, 2022 14:08
@Haroenv Haroenv changed the title feat(client-search): Updating searchoptions with explain attribute fix(types): Updating searchoptions with explain attribute Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TypeScript Problems related to TypeScript definitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants