Skip to content

# fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2022
Merged

# fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd0997
fix(types): updating reRankingApplyFilter type
alphonseb Feb 22, 2022
50209ca
feat: add property to hit's rankinginfo
alphonseb Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/client-search/src/types/Hit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export type RankingInfo = {
readonly rankingScore: number;
readonly score: number;
};
readonly promotedByReRanking?: boolean;
};

export type Hit<THit> = THit & {
Expand Down
3 changes: 2 additions & 1 deletion packages/client-search/src/types/SearchOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,5 +366,6 @@ export type SearchOptions = {
readonly reRankingApplyFilter?:
| string
| readonly string[]
| ReadonlyArray<readonly string[] | string>;
| ReadonlyArray<readonly string[] | string>
| null;
};
3 changes: 2 additions & 1 deletion packages/client-search/src/types/Settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,5 +359,6 @@ export type Settings = {
readonly reRankingApplyFilter?:
| string
| readonly string[]
| ReadonlyArray<readonly string[] | string>;
| ReadonlyArray<readonly string[] | string>
| null;
};