Skip to content

fix(api-keys): fix typing issues #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

fix(api-keys): fix typing issues #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca18b37
fix(api-keys): fix GetApiKeyResponse createdAt attribute typing
kombucha Apr 28, 2021
7adea8d
fix(api-keys): missing attribute in UpdateApiKeyOptions
kombucha Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/client-search/src/types/GetApiKeyResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ import { ApiKeyACLType } from '.';

export type GetApiKeyResponse = {
/**
* A Unix timestamp used to define the expiration date of the API key.
* The api key value
*/
value: string;

/**
* Date of creation.
* Date of creation (Unix timestamp).
*/
createdAt: string;
createdAt: number;

/**
* List of permissions the key contains.
Expand Down
7 changes: 7 additions & 0 deletions packages/client-search/src/types/UpdateApiKeyOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { ApiKeyACLType } from '.';

export type UpdateApiKeyOptions = {
/**
* List of permissions the key contains.
*/
readonly acl?: readonly ApiKeyACLType[];

/**
* A Unix timestamp used to define the expiration date of the API key.
*/
Expand Down