fix(getSettings): allow empty call (algolia#664)

Author: Haroenv

src/Index.js

@@ -608,12 +608,15 @@ Index.prototype.clearIndex = function(callback) {
 * @param opts.advanced get more settings like nbShards (useful for Enterprise)
 * @param callback (optional) the result callback called with two arguments
 *  error: null or Error('message')
-*  content: the settings object or the error message if a failure occured
+*  content: the settings object or the error message if a failure occurred
 */
 Index.prototype.getSettings = function(opts, callback) {
-  if (arguments.length === 1 || typeof opts === 'function') {
-    callback = opts;
-    opts = {};
+  if (arguments.length < 2) {
+    if (typeof opts === 'function') {
+      callback = opts;
+      opts = {};
+    }
+    opts = opts || {};
   }
 
   var indexName = encodeURIComponent(this.indexName);

test/run-integration.js

@@ -48,6 +48,7 @@ _.bindAll(index);
 test('index.clearIndex', clearIndex);
 if (canPUT) {
   test('index.setSettings', setSettings);
+  test('index.getSettings', getSettings);
 }
 test('index.saveObjects', saveObjects);
 if (canPUT) {
@@ -137,6 +138,20 @@ function setSettings(t) {
     .then(noop, _.bind(t.error, t));
 }
 
+function getSettings(t) {
+  t.plan(2);
+
+  index
+    .setSettings({attributesForFaceting: ['searchable(category)']})
+    .then(function() {return index.getSettings({advanced: 1});})
+    .then(get('attributesForFaceting'))
+    .then(_.partialRight(t.deepEqual, ['searchable(category)'], 'Settings were get (advanced)'))
+    .then(index.getSettings)
+    .then(get('attributesForFaceting'))
+    .then(_.partialRight(t.deepEqual, ['searchable(category)'], 'Settings were get'))
+    .then(noop, _.bind(t.error, t));
+}
+
 function searchForFacetValues(t) {
   t.plan(1);